Repository navigation
Add pinned SuperNOVAS QC for native and Wasm charts - #16
Draft
jacksteamdev wants to merge 4 commits into
Draft
jacksteamdev wants to merge 4 commits into
jacksteamdev wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opt-in QC for fifteen planetary/derived bodies, including Ceres/Chiron and osculating nodes with symbolic South declination, reported offsets, original IAU 2000B nutation, twelve cusps and four angles. It validates reference provenance/models/echoed inputs and records source/native/Wasm hashes, all cases and reference geometry. Native/Wasm attempts are independent.
Based on
fix/lahiri-full-nutation-importat9f84a6e9ec815fb52418f26d98a6ccdd78d688dd(PR #15). Library calculations and regression fixtures are unchanged. Effective TT/UT1 diagnostics remain distinct from planetary checks at physical TT.Evidence
After: 831 cases, including 423 chart inputs, complete 53,457 numerical checks with zero numerical failures. This includes 4,932 Ceres/Chiron checks against pinned Horizons inputs.
tools/verification/novas-qc-findings.md.06d4c26e589207bf479dbd217fafb3e4d6c559626425b156912e39a4d859487b. Tampered node models and geometry identity fail with exit 2; numerical perturbations fail with exit 1.Merge Danger
Door: two-way
Blast Radius: tooling
Coverage remains partial: mean-node/geometric-South modes and True Sky are excluded. Regular PR CI is distinct from the failing opt-in full-data QC gate. The new manual hosted QC workflow has not been dispatched.