Repository navigation
Point share links at the GitHub repo with working intent URLs - #22
Merged
Merged
Conversation
screenchart.app isn't deployed, so sharing it yields a blank preview card. Use the live GitHub repo URL as the single shared URL (TODO to switch back once the site ships OG tags). Update the share text, and wire X to twitter.com/intent and WhatsApp to wa.me per their current intent endpoints; LinkedIn/Facebook/Reddit/Telegram already matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
screenchart.app isn't deployed yet, so sharing it produces a blank preview card. Point every social button at the live GitHub repo (which renders a proper card) and verify each intent endpoint.
Changes (
renderer/hub/hub.js)SHARE_URL=GITHUB_URL(https://github.com/AshishB2000/screenchart), with aTODOto switch back to screenchart.app once it ships OG tags.SHARE_TEXT→ "Screenchart: screenshot any chart, table, or data and get instant AI analysis. Local-first, bring your own key."twitter.com/intent/tweet?url=&text=(wasx.com); WhatsApp →wa.me/?text=(wasapi.whatsapp.com/send). LinkedIn/Facebook/Reddit/Telegram already matched the spec.Endpoint check
All six URLs parse via
new URL()and encode correctly. LinkedIn usesshare-offsite(attaches a preview); Facebooksharer; Reddit/submit; Telegramt.me/share/url.Buttons open via
shell.openExternal(default browser). The GitHub row already opens the repo — unchanged.