Repository navigation
[BREAKING][fix] Remove controller-side waiting from metadata fetches - #217
Merged
Merged
Conversation
Check ready samples once so the request loop can continue processing producer notifications. Keep sampler cache hits available and return an empty BatchMeta when no batch is ready. Warn on legacy polling_mode settings and remove them from examples and fixtures. Signed-off-by: 0oshowero0 <o0showero0@outlook.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: 0oshowero0 <o0shower0o@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GET_METAandNOTIFY_DATA_UPDATEshare the controller’s ZMQ request loop. When a fetch waits for samples, it delays the producer notifications that would mark those samples as ready.Changes
polling_modefrom default configs, tutorials, recipes, benchmarks, and E2E fixtures.Breaking change
With the previous default
polling_mode=False,get_meta()andasync_get_meta()waited for a batch and raised an error on timeout. They now return an emptyBatchMetaimmediately when no batch is available.Callers that relied on waiting should check
metadata.size == 0and retry before callingget_data().StreamingDatasetalready handles empty batches and retries. Client-side waiting and automatic retries will be implemented in a follow-up. #212Remove
controller.polling_modefrom configs andpolling_modefrom controller constructor calls. Both are accepted and ignored in this release, emit aFutureWarningwhen supplied, and will be removed in the next release.Validation
Compilation, Ruff, and 313 targeted tests passed. The full suite stopped during Ray startup due to local permission restrictions.