Skip to content

[Cycode] Fix for SAST detections - Unsanitized external input in SQL query #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cycode-security wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Cycode] Fix for SAST detections - Unsanitized external input in SQL query #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/main/java/org/owasp/webgoat/lessons/sqlinjection/mitigation/Servers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@

/*
* SPDX-FileCopyrightText: Copyright © 2017 WebGoat authors
* SPDX-License-Identifier: GPL-2.0-or-later
Expand Down Expand Up @@ -45,12 +46,17 @@ public Servers(LessonDataSource dataSource) {
public List<Server> sort(@RequestParam String column) throws Exception {
List<Server> servers = new ArrayList<>();

// Validate column parameter against whitelist
List<String> allowedColumns = List.of("id", "hostname", "ip", "mac", "status", "description");
if (!allowedColumns.contains(column)) {
throw new IllegalArgumentException("Invalid column name");
}

try (var connection = dataSource.getConnection()) {
try (var statement =
connection.prepareStatement(
"select id, hostname, ip, mac, status, description from SERVERS where status <> 'out"
+ " of order' order by "
+ column)) {
"select id, hostname, ip, mac, status, description from SERVERS where status <> 'out of order' order by ?")) {
statement.setString(1, column);
try (var rs = statement.executeQuery()) {
while (rs.next()) {
Server server =
Expand Down