fix(ethereum2): receipt-local event indices and legacy proof compatibility - #84
Draft
fengjy73 wants to merge 4 commits into
Draft
fix(ethereum2): receipt-local event indices and legacy proof compatibility#84fengjy73 wants to merge 4 commits into
fengjy73 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ethereum JSON-RPC logIndex is block-global, while the receipt proof authenticates one transaction's logs array. The collector stored the global value and HCDVS indexed the receipt with it, rejecting valid AM messages in later transactions of a block. The filter collector also expanded every matched log into every AM event in its receipt, duplicating/mixing messages.
Fix
Based on upstream main ec89a28; preserves the existing consensus/light-client fixes. This PR contains only generic Ethereum2 changes, not downstream Ethereum3/regulatory code.
Tests
Downstream deployment evidence
The equivalent downstream fix (ICT PR #7) was deployed to the Plugin Server and all four PTC nodes. This is not a claim that the upstream branch artifact was installed.
Runbook: acb-sdk/pluginset/ethereum2/RECEIPT_LOG_INDEX.md. Collector and every committee member's HCDVS should be deployed together with component-specific rollback backups. Unexecuted Mychain ordinary / native Dioxide SDP V2/V3 combinations are not counted as passed.