Antalya 26.6: S3 tables Iceberg support + catalog profile events - #2184
Open
zvonand wants to merge 4 commits into
Open
Antalya 26.6: S3 tables Iceberg support + catalog profile events#2184zvonand wants to merge 4 commits into
zvonand wants to merge 4 commits into
Conversation
…next commit) --- Original cherry-pick message follows: Merge pull request #1808 from Altinity/antalya_26_3_s3_tables Antalya 26.3: S3 tables iceberg support # Conflicts: # src/Databases/DataLake/DatabaseDataLake.cpp # src/Databases/DataLake/RestCatalog.cpp
RestCatalog.cpp: kept antalya-26.6's endpoint construction for createNamespaceIfNotExists / createTable / updateMetadata (it already composes base_url / config.prefix / NAMESPACES_ENDPOINT, which is what the PR was introducing, plus namespace URI encoding). Applied the PR's dropTable endpoint change (adds config.prefix); dropped the allowed_namespaces filter block, which is not part of #1808's diff and has no counterpart on antalya-26.6. DatabaseDataLake.cpp: the "Engine `Iceberg` must have `rest` catalog type only" check that #1808 extended no longer exists on antalya-26.6 (Iceberg engine now also serves onelake/biglake/hive catalogs), so the extended check is not re-introduced. Source-PR: #1808 (#1808)
…next commit) --- Original cherry-pick message follows: Merge pull request #1868 from Altinity/fix/datalake-rest-catalog-profile-events Profile events for Iceberg catalogs # Conflicts: # src/Common/ProfileEvents.cpp # src/Databases/DataLake/RestCatalog.cpp # src/Databases/DataLake/UnityCatalog.cpp
Kept antalya-26.6's paginated getNamespaces()/getTables() loops in RestCatalog and its extracted UnityCatalog credential helpers, placing the PR's profile-event counters/timers at the corresponding request sites. Dropped the ObjectStorageListObjectsCache* rows that came along as context from the merge commit but are not part of #1868 and do not exist on antalya-26.6. Adapted: RestCatalog::getNamespaces/getTables — counters/timers moved inside antalya-26.6's page loops Adapted: UnityCatalog credentials counter/timer moved into the extracted requestReadCredentials() helper Source-PR: #1868 (#1868)
zvonand
added
releasy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add initial experimental support for S3 Tables via the Iceberg serverless REST catalog with SigV4 authentication, enabled by the allow_experimental_database_s3_tables setting. Also add profile events tracking requests to Iceberg REST, Glue, and Unity catalogs.
Add initial experimental support for S3 Tables via the Iceberg serverless REST catalog with SigV4 authentication, enabled by the allow_experimental_database_s3_tables setting. Also add profile events tracking requests to Iceberg REST, Glue, and Unity catalogs (#1808 by @subkanthi, #1868 by @ianton-ru).
CI/CD Options
Exclude tests:
Regression jobs to run:
Combined port of 2 PR(s) (group
auto-grp-pr-1808). Cherry-picked from #1808, #1868.