Skip to content

977 feature implement daily task your voice - #983

Merged
CapoMK25 merged 4 commits into
devfrom
977-feature-implement-daily-task-YOUR_VOICE
Sep 14, 2026
Merged

CapoMK25 merged 4 commits into
devfrom
977-feature-implement-daily-task-YOUR_VOICE

Conversation

@EemeliJ

@EemeliJ EemeliJ commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Brief description

Adds the server-tracked YOUR_VOICE daily task for participating in an existing clan voting. The task progresses only after an authorized player’s vote is successfully saved.

Change list

  • Add YOUR_VOICE to generated server daily tasks with a Finnish title.
  • Replace the legacy PARTICIPATE_CLAN_VOTING event with YOUR_VOICE.
  • Require the voting to belong to the voter’s current clan before progressing the task.
  • Await the daily-task event after vote persistence succeeds.
  • Add coverage for successful voting, permission denial, and failed vote paths.
  • Update daily-task generation and startup-refresh test coverage.

Generate the new server-tracked task and progress it only after an authorized clan vote is saved.
Generate the server-tracked task and emit its progress only after an authorized clan vote is saved.
@codecov-alt

codecov-alt Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/box/accountClaimer/payloads/claimedAccount.ts 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/auth/auth.service.ts 98.57% <100.00%> (ø)
src/box/accountClaimer/accountClaimer.service.ts 94.73% <100.00%> (ø)
src/box/auth/BoxAuthHandler.ts 96.96% <100.00%> (ø)
src/dailyTasks/taskGenerator.service.ts 96.15% <100.00%> (+0.15%) ⬆️
src/voting/voting.service.ts 86.50% <100.00%> (+0.51%) ⬆️
src/box/accountClaimer/payloads/claimedAccount.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CapoMK25 CapoMK25 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid and simple, approved.

@github-project-automation github-project-automation Bot moved this from Backlog to Done in Altzone-Server Sep 14, 2026
@CapoMK25
CapoMK25 merged commit b1cd5a3 into dev Sep 14, 2026
5 checks passed
@CapoMK25
CapoMK25 deleted the 977-feature-implement-daily-task-YOUR_VOICE branch September 14, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants