Skip to content

979 feature request update the serverside furnitures to match the furniture on the clientside - #982

Merged
CapoMK25 merged 4 commits into
devfrom
979-feature-request-update-the-serverside-furnitures-to-match-the-furniture-on-the-clientside
Sep 14, 2026
Merged

CapoMK25 merged 4 commits into
devfrom
979-feature-request-update-the-serverside-furnitures-to-match-the-furniture-on-the-clientside

Conversation

@tickBit

@tickBit tickBit commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Brief description

Related issue #979

Added new items with their properties from given Google sheet.

Change list

  • Manually copy-pasted and changed itemName.enum.ts.
  • changed src/clan/utils/defaultValues/items.ts accordingly
  • With AI's assistance read the online sheet to re-create itemProperties.ts
  • Lots of test files modified because of new and left out items

Note:

The sheet lacks some info on some items. That is why there is type undefined used in some places.

I learned also, that in UI side uses all the 3 dimensions of the items. Now they're also in the server side.

We seem to also lack enum value for "biojäte" for recycling.

@codecov-alt

codecov-alt Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/clan/utils/defaultValues/items.ts 100.00% <ø> (ø)
src/clanInventory/item/const/itemProperties.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tickBit

tickBit commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

I may get some new info for undefined values, if the info is available anywhere.

@tickBit

tickBit commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

Now there is all the info about the items, that we have at the moment.

@CapoMK25 CapoMK25 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, approved!

@github-project-automation github-project-automation Bot moved this from Backlog to Done in Altzone-Server Sep 14, 2026
@CapoMK25
CapoMK25 merged commit 5d20a93 into dev Sep 14, 2026
5 checks passed
@CapoMK25
CapoMK25 deleted the 979-feature-request-update-the-serverside-furnitures-to-match-the-furniture-on-the-clientside branch September 14, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feature request: Update the serverside furnitures to match the furniture on the clientside

2 participants