Conversation
lexBarePlaceholder has no return-nil path — an unquoted '<' is always a parse error by design (PT-02(b)) — so `if err := ...; err != nil` at the call site was flagged by staticcheck (SA4023: always-true comparison) as pre-existing tech debt blocking the required Lint CI check on main (confirmed unrelated to FP-10/#265/#266). Collapses to a direct `return l.lexBarePlaceholder()` — behaviorally identical, since err was always non-nil anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main(surfaced and confirmed unrelated while merging fix: tap no longer bypasses occlusion via the direct-invoke fast path (FP-10) #266/FP-10).lexBarePlaceholder(internal/parser/lexer.go:149) has no return-nil path — an unquoted<is always a parse error by design (see PT-02(b)'s doc comment on that function). staticcheck's SA4023 correctly flagged the call site'sif err := l.lexBarePlaceholder(); err != nilas an always-true comparison, plus a "never returns nil" hint.return l.lexBarePlaceholder()— behaviorally identical, sinceerrwas always non-nil anyway; just removes the now-provably-dead branch.Test plan
staticcheck ./...— 0 issues (previously failed on this exact file/line)go vet ./...,go build ./...— cleango test ./...— full suite passes, includinginternal/parserlexer tests