Repository navigation
Make schedule review handoffs compact and revision-bound - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schedule reviewers previously received every decision as an empty prompt, a large first-work preview, and an old narrative prefilled as today's conclusion. Review packets now distinguish unchanged dispositions from decisions requiring a fresh review and show before/after rule configuration, population, sources, allowed windows, and overdue cutoffs as of the stated date. Withdrawn excluded proposals remain visible.
The CLI prints only decisions requiring review and omits the detailed operating preview unless
--include-operating-previewis requested. Generated commands create private exclusive drafts outside the checkout with--outputand use compact--summary --jsonpreviews and saves; existing drafts, symlink targets and authoritative source files cannot be overwritten. Fresh reviewer, date and conclusion fields start blank. Planned prompts, including partially completed drafts, do not appear as prior completed reviews. Reviewers may explicitly reaffirm unchanged dispositions against both the exact current collection revision and prior review-record revision; the server reconstructs and validates the complete decision set from trusted historical source facts. Client packet metadata cannot authorize reuse. Existing full-array payloads and domain API preview defaults remain supported.The browser uses the same packet, requires explicit unchanged confirmation, and preserves direct review intent while lazy state loads. Prior decisions and narratives remain historical context. No schedule, policy activation, approval identity requirement, or data model changes.
Validation: seven independent combined code/security passes converged after fixing summary counts for explicit overrides and including timezone in timing context and preserving direct-link intent across both lazy-state readiness orders; the final pass found no actionable issues; Node 24
CI=true npm run validate; focused packet, source freshness, cache, rendering, and collection-review regressions; actual 57-schedule preview/save with four changed decisions and 53 explicit reaffirmations, legacy payload compatibility, untrusted client metadata, missing/replaced prior bindings, missing historical baseline, stale source edits, reviewer conflicts, retained prior history, and unchanged activation facts. Playwright exercised the cold direct-review link with both deterministically delayed readiness orders, permanent read-only behavior, empty identity/conclusion fields, changed-window details, explicit confirmation, actual successful save, and current gate with no console errors or failed requests. The dedicated local server was stopped. Fresh generated 224-resource consumer validates without errors or warnings; both package dry runs, npm audit, and private-source/secret scans passed.Coordinated patch release: 0.21.15, no model migration.