Skip to content

[PWGLF,PWGMM] Add a new task for vertex-based vdM scan analyses - #17361

Open
mjkim525 wants to merge 7 commits into
AliceO2Group:masterfrom
mjkim525:master
Open

[PWGLF,PWGMM] Add a new task for vertex-based vdM scan analyses#17361
mjkim525 wants to merge 7 commits into
AliceO2Group:masterfrom
mjkim525:master

Conversation

@mjkim525

@mjkim525 mjkim525 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This PR introduces a new lumiVertex analysis task for vertex-based van der Meer scan analyses such as Length-Scale Calibration, Non-factorization effect correction.

The task is based on the existing PWGMM/Lumi/Tasks/lumi.cxx workflow and is designed to store the primary-vertex and bunch-crossing information needed for luminosity studies based on reconstructed collision vertices.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 3 disabled

@github-actions github-actions Bot changed the title Add new codes for vertex based vdM scan analyses [PWGLF,PWGMM] Add new codes for vertex based vdM scan analyses Aug 6, 2026
[PWGLF,PWGMM] Please consider the following formatting changes to AliceO2Group#17361
@mjkim525 mjkim525 changed the title [PWGLF,PWGMM] Add new codes for vertex based vdM scan analyses [PWGLF,PWGMM] Add a new task for vertex-based vdM scan analyses Aug 6, 2026
@mjkim525
mjkim525 marked this pull request as ready for review August 7, 2026 03:00
@alibuild

alibuild commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 1a963b5 at 2026-08-07 05:07:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/8b1be657340555923db73971d79fbc3d4c32ca10/O2Physics-code-check/errors.txt
PWGMM/Lumi/Tasks/lumiVertex.cxx:22:1: error: included header TrackSelectionTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/Lumi/Tasks/lumiVertex.cxx:116:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGMM/Lumi/Tasks/lumiVertex.cxx:283:12: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGMM/Lumi/Tasks/lumiVertex.cxx:284:12: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGMM/Lumi/Tasks/lumiVertex.cxx:690:13: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@jgcn jgcn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
I see still some errors. Unfortunately, I am not a C++ expert so I have no concrete suggestions. Could you please have a look to see if you manage to solve at least some of them? If you do not manage, and you assure me that these are more warnings than errors, I could approve the new code. (Unless someone else in the list of people that grant approvals, and who have a lot more C++ knowledge than I, has another opinion .)
have a nice day
guillermo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants