Skip to content

[PWGCF] Added multiplicity axis for v02pt + linter fixes - #17313

Open
MaximVirta wants to merge 8 commits into
AliceO2Group:masterfrom
MaximVirta:V02
Open

[PWGCF] Added multiplicity axis for v02pt + linter fixes#17313
MaximVirta wants to merge 8 commits into
AliceO2Group:masterfrom
MaximVirta:V02

Conversation

@MaximVirta

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 3 disabled

Please consider the following formatting changes to AliceO2Group#17313
@alibuild

alibuild commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for bf40b57 at 2026-08-04 14:09:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 43 errors and 62 warnings.'
Found 43 errors and 62 warnings.
++ [[ 43 -gt 0 ]]
++ cat /sw/BUILD/be5d6db149bcc4cda8bcc4efe006de221e2321c8/O2Physics-code-check/errors.txt
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:77:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:103:3: error: variable 'gfwMemberCache' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:308:39: error: Assigned value is garbage or undefined [clang-analyzer-core.uninitialized.Assign,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:418:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:510:139: error: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:513:131: error: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:518:5: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:527:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:571:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:584:31: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:584:57: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:593:27: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:604:10: error: variable 'isPion' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:604:18: error: variable 'isKaon' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:604:26: error: variable 'isProton' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:615:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:663:96: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:665:90: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:703:31: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:712:31: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:719:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:724:33: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:841:9: error: implicit conversion 'unspecified_bool_type' (aka '__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>> boost::iterator_range_detail::iterator_range_base<__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>>, boost::iterators::incrementable_traversal_tag>::*') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:843:9: error: implicit conversion 'unspecified_bool_type' (aka '__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>> boost::iterator_range_detail::iterator_range_base<__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>>, boost::iterators::incrementable_traversal_tag>::*') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:845:9: error: implicit conversion 'unspecified_bool_type' (aka '__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>> boost::iterator_range_detail::iterator_range_base<__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>>, boost::iterators::incrementable_traversal_tag>::*') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:867:32: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:980:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:996:36: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:996:55: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1022:34: error: use designated initializer list to initialize 'AcceptedTracks' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1069:34: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1082:29: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1090:34: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1139:30: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1164:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1168:32: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1232:34: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1249:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1252:38: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1268:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1289:22: error: use designated initializer list to initialize 'XAxis' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1314:22: error: use designated initializer list to initialize 'XAxis' [modernize-use-designated-initializers,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e64e0bc at 2026-08-04 14:41:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 43 errors and 62 warnings.'
Found 43 errors and 62 warnings.
++ [[ 43 -gt 0 ]]
++ cat /sw/BUILD/f6603c3828fa5220d9f62c8c95cfc932b283f946/O2Physics-code-check/errors.txt
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:77:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:103:3: error: variable 'gfwMemberCache' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:308:39: error: Assigned value is garbage or undefined [clang-analyzer-core.uninitialized.Assign,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:418:19: error: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:510:139: error: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:513:131: error: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:518:5: error: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:527:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:571:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:584:31: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:584:57: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:593:27: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:604:10: error: variable 'isPion' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:604:18: error: variable 'isKaon' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:604:26: error: variable 'isProton' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:615:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:663:96: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:665:90: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:703:31: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:712:31: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:719:5: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:724:33: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:841:9: error: implicit conversion 'unspecified_bool_type' (aka '__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>> boost::iterator_range_detail::iterator_range_base<__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>>, boost::iterators::incrementable_traversal_tag>::*') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:843:9: error: implicit conversion 'unspecified_bool_type' (aka '__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>> boost::iterator_range_detail::iterator_range_base<__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>>, boost::iterators::incrementable_traversal_tag>::*') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:845:9: error: implicit conversion 'unspecified_bool_type' (aka '__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>> boost::iterator_range_detail::iterator_range_base<__gnu_cxx::__normal_iterator<const char *, std::basic_string<char>>, boost::iterators::incrementable_traversal_tag>::*') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:867:32: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:980:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:996:36: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:996:55: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1022:34: error: use designated initializer list to initialize 'AcceptedTracks' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1069:34: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1082:29: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1090:34: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1139:30: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1164:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1168:32: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1232:34: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1249:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1252:38: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1268:5: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1289:22: error: use designated initializer list to initialize 'XAxis' [modernize-use-designated-initializers,-warnings-as-errors]
PWGCF/GenericFramework/Tasks/flowGfwV02.cxx:1314:22: error: use designated initializer list to initialize 'XAxis' [modernize-use-designated-initializers,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for e64e0bc at 2026-08-04 18:30:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants