[ALICE3] Fix CodeCleaner errors in alice3DQTableMaker - #17305
Open
axti98 wants to merge 2 commits into
Open
Conversation
|
O2 linter results: ❌ 0 errors, |
njacazio
marked this pull request as ready for review
August 3, 2026 19:24
njacazio
requested review from
alibuild,
hscheid,
jesgum and
njacazio
as code owners
August 3, 2026 19:24
njacazio
enabled auto-merge (squash)
August 3, 2026 19:25
Collaborator
|
Error while checking build/O2Physics/code-check for ff0ec26 at 2026-08-04 11:40: Full log here. |
vkucera
reviewed
Aug 3, 2026
Comment on lines
+469
to
+471
| auto trackFilteringTag = static_cast<uint64_t>(0); | ||
| auto trackTempFilterMap = static_cast<uint32_t>(0); | ||
| auto mcflags = static_cast<uint16_t>(0); |
Collaborator
There was a problem hiding this comment.
Why not simply just uint64_t trackFilteringTag{0}?
Collaborator
|
What is CodeCleaner? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.