Repository navigation
TPC SCD: TrackResiduals y/x grid edge from the pad plane - #16040
Merged
wiechula merged 1 commit intoNov 3, 2026
Merged
Conversation
The y/x range of the voxel grid was x tan(10 deg) - 1.5 cm (a fixed dead zone) per x bin. It does not follow the pad plane (the number of pads per row grows in steps, the pad width changes per region): relative to the outer side of the row's last pad it ends -0.83 to +0.33 pads off (negative: inside the pad plane), inside in 112 of 152 rows, in 36 of them by more than half a pad (the last pad's centre outside the grid), outside (in the gap to the next sector) in 40. Bins refined at the sector edges therefore covered a different part of the pad plane in each row. Now y/x = +-maxY2X is half the row's pads times its pad width (Mapper), for uniform X-binning the pad row closest to the bin centre. Unit test: the edge in every row. Maps binned with the old definition are to be read with an O2 version from before this change (their trees store bin indices and mean positions, the bin centres come from TrackResiduals). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
November 3, 2026 10:42
wiechula
enabled auto-merge (rebase)
November 3, 2026 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The y/x range of the voxel grid was x tan(10 deg) - 1.5 cm (a fixed dead zone) per x bin. It does not follow the pad plane (the number of pads per row grows in steps, the pad width changes per region): relative to the outer side of the row's last pad it ends -0.83 to +0.33 pads off (negative: inside the pad plane), inside in 112 of 152 rows, in 36 of them by more than half a pad (the last pad's centre outside the grid), outside (in the gap to the next sector) in 40. Bins refined at the sector edges therefore covered a different part of the pad plane in each row. Now y/x = +-maxY2X is half the row's pads times its pad width (Mapper), for uniform X-binning the pad row closest to the bin centre. Unit test: the edge in every row.
Maps binned with the old definition are to be read with an O2 version from before this change (their trees store bin indices and mean positions, the bin centres come from TrackResiduals).