Repository navigation
AODNative: link Threads::Threads publicly - #16034
Merged
Merged
Conversation
Decoder.cxx and test_ReadPlan.cxx use std::thread, but neither the
library nor its test executable linked the threads library. With
glibc < 2.34 (e.g. EL8/slc8) pthread_* live in libpthread, so linking
fails with -Wl,--no-undefined:
libO2AODNative.so: undefined reference to `pthread_create'
o2-test-framework-aod-native: undefined reference to symbol
'pthread_join@@GLIBC_2.2.5' / DSO missing from command line
Newer glibc merges libpthread into libc, which hides the problem there.
Make Threads::Threads a public dependency so all consumers get it.
ktf
approved these changes
Nov 2, 2026
ktf
left a comment
ktf
left a comment
Member
There was a problem hiding this comment.
Looks reasonable, even if EL8 is not really supported anymore.
Contributor
Author
We will upgrade this year to AlmaLinux 9. 😅 |
Member
|
Error unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decoder.cxx and test_ReadPlan.cxx use std::thread, but neither the library nor its test executable linked the threads library. With glibc < 2.34 (e.g. EL8/slc8) pthread_* live in libpthread, so linking fails with -Wl,--no-undefined:
libO2AODNative.so: undefined reference to `pthread_create'
o2-test-framework-aod-native: undefined reference to symbol
'pthread_join@@GLIBC_2.2.5' / DSO missing from command line
Newer glibc merges libpthread into libc, which hides the problem there. Make Threads::Threads a public dependency so all consumers get it.