Skip to content

Skip invalid timeframes during ROOT input - #15576

Open
autumn-mck wants to merge 1 commit into
AliceO2Group:devfrom
autumn-mck:fault-tolerence
Open

Skip invalid timeframes during ROOT input#15576
autumn-mck wants to merge 1 commit into
AliceO2Group:devfrom
autumn-mck:fault-tolerence

Conversation

@autumn-mck

Copy link
Copy Markdown
Contributor

Handle corrupt reads as recoverable, discarding the timeframe

@ktf

ktf commented Jul 6, 2026

Copy link
Copy Markdown
Member

thank you for your contribution. somehow i did not get notified about this. i will have a look at it tomorrow, time permitting. One comment i already have is that you can probably split the changes to LifetimeHolder as a separate PR.

Comment thread Framework/Core/include/Framework/DataAllocator.h Outdated
Comment thread Framework/AnalysisSupport/src/TTreePlugin.cxx
Handle corrupt reads as recoverable and discard the affected timeframe when DPL_AOD_READER_SKIP_INVALID is enabled.
@autumn-mck
autumn-mck marked this pull request as ready for review August 3, 2026 13:30
@autumn-mck
autumn-mck requested a review from a team as a code owner August 3, 2026 13:30
@ktf

ktf commented Aug 3, 2026

Copy link
Copy Markdown
Member

The part about the MessageContext can also be merged separately. Can you spawn a new PR?

@jgrosseo

jgrosseo commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

@ktf Do you have other comments apart from the splitting?

@ktf

ktf commented Aug 4, 2026

Copy link
Copy Markdown
Member

I did not look into the details of the rest. I will do once I am back, tomorrow.

@ktf

ktf commented Aug 4, 2026

Copy link
Copy Markdown
Member

We should also think how to test this, e.g. making sure it actually does not get stuck or silently skips stuff.

@jgrosseo

jgrosseo commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

We should also think how to test this, e.g. making sure it actually does not get stuck or silently skips stuff.

Once we can enable it by environment variable, we plan to clone some trains which had large number of failures, enable the feature only for those, and do a detailed inspection of the logs and output.

@alibuild

alibuild commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 39c7515 at 2026-08-04 18:00:

No log files found

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants