Draft
Fix AUTOINCREMENT not populating identity columns in IndexedDB tables#2526
Conversation
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix autoincrement not working for IndexedDB
Fix AUTOINCREMENT not populating identity columns in IndexedDB tables
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUTOINCREMENT(mapped toIDENTITY) columns were silently dropped when inserting into IndexedDB-backed tables — the column was absent entirely from query results rather than receiving an auto-incremented value.Root cause
IDB.intoTablepassed records directly to IndexedDB without applying the table'sidentitiescounter, bypassing the logic that both the in-memorytable.insertpath andLS.intoTable(LocalStorage) already handle.Changes
src/91indexeddb.js—IDB.intoTable: Before writing records to the object store, iteratetable.identitiesand assign the current counter value to any record missing that column, then advance the counter (or sync it forward if the user supplied an explicit value ≥ the current counter).test/test861.js: Browser-only tests verifying AUTOINCREMENT values are populated on insert and continue incrementing across multipleINSERTstatements.