Conversation
This commit adds the missing tone sandhi rule for the Dapu dialect (da) in sandhi_rules.json, where two consecutive 33 (陰平) tones trigger the first tone to change to 35 (陰上). A corresponding unit test case is also added in tests/sandhi_fixture_test.js to verify the change. Co-authored-by: Aiuanyu <93833368+Aiuanyu@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying hakspring with
|
| Latest commit: |
d534ba5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a3f7f999.hakspring.pages.dev |
| Branch Preview URL: | https://jules-17932127947538961153-3.hakspring.pages.dev |
ReviewClean, minimal, data-only fix — nice work. Correctness
Test coverage
Other
Looks good to merge once CI passes. |
Add the missing Dapu 33+33 -> 35 tone sandhi rule in
sandhi_rules.jsonand a corresponding test case intests/sandhi_fixture_test.js.Fixes #239
PR created automatically by Jules for task 17932127947538961153 started by @Aiuanyu