Skip to content

ci(fast-path): never save caches; per-run concurrency - #44

Merged
khaliqgant merged 1 commit into
mainfrom
ci/fast-path-hardening
Nov 15, 2026
Merged

khaliqgant merged 1 commit into
mainfrom
ci/fast-path-hardening

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Hardens the approval-gated fast path (.github/workflows/fast-path.yml) from the earlier fast-path PR. Normal CI is unchanged, and Khaliq still approves the fast-path environment before anything runs on Blacksmith.

Cache poisoning: the fast path builds unreviewed refs, so it must never save into a cache that normal CI or release workflows restore. Removes cache: npm from all three actions/setup-node steps.

Concurrency: the workflow-level group now includes github.run_id. With a group keyed only by ref, a later dispatch could cancel a run that was still waiting for approval.

No workflow test harness exists in this repo, so no property test was added.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff

The fast path builds unreviewed refs, so it must not save into caches that
normal CI restores. The workflow concurrency group gets github.run_id so a
later dispatch cannot cancel a run that is waiting for approval.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e9008d45-fc49-4607-88ee-5d87c045021b
Commits

Reviewing files that changed from the base of the PR and between 2ee1f6e and c213bcd.

Files selected for processing: 1

  • .github/workflows/fast-path.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T19:23:35.578507Z c213bcd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@greptile-apps

greptile-apps Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Hardens .github/workflows/fast-path.yml without changing normal CI.

  • Fast-path jobs no longer use npm caches.
  • Each fast-path dispatch gets its own concurrency group.

No actionable issues found. Review was based on source checks; the workflow was not run.

Reviews (1) · Last reviewed commit: "ci(fast-path): never save caches; per-ru..." · Reviewed by Greptile

@khaliqgant
khaliqgant merged commit 74e76ba into main Nov 15, 2026
8 of 9 checks passed
@khaliqgant
khaliqgant deleted the ci/fast-path-hardening branch November 15, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant