Repository navigation
fix(dm): a thread reply under a DM is a DM to the other participant - #44
Conversation
Agent Relay clients (relay-node auto-answers, MCP reply) answer a DM with POST /v1/messages/:id/replies, which relaygate refused as dm_message, so replies between local agents never arrived. A participant's reply is now decided exactly as POST /v1/dm to the other participant (w on their inbox, classifier as usual) and forwarded with provenance. Non-participants are refused (dm_reply_not_participant); reactions under a DM stay refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b7a945a3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Resolving the other participant from message authors failed when the sender followed up before the recipient wrote anything. Use GET /v1/dm/conversations (the caller's conversations, unpaged, with participants) instead, and pass an upstream failure (429/5xx) back rather than refusing the reply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
After a local agent DMs another (
dm.sendallowed), the recipient's answer viathread.replyonrelaycast:message/<dm message id>was denied at stagemode, reasondm_message. Agent Relay clients (relay-node auto-answers, MCP reply) reply to DMs this way, so replies between local agents never arrived.Fix
POST /v1/messages/:id/replieson a DM message:GET /v1/dm/<conversation>/messagesanswers participants only); otherwise deny,dm_reply_not_participantPOST /v1/dmto them:gateWriteonrelaycast:inbox/<other>(mode, ACL, ceilings, classifier on cross-group), audited under that inbox idfromstripped, provenance stamped)So local↔local is allowed; pit→local is still denied by the local inbox mode/ACL. Reactions under a DM stay refused.
docs/contract.mdroute table updated. Independent of #43 (which makescursor-…/claude-…inboxes resolvable); both are needed for Desktop agents.Tests
test/relaycast.test.ts, "a thread reply under a DM is a DM to the other participant": local B replies to local A's DM → 201, forwarded, audited against A's inbox; A replies under its own message → B's inbox; non-participant local C → 403; pit replying to local A's DM → 403 (mode:660+acl:22:r); reactions under DM → 403. Typecheck + full suite green.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Thread replies under DMs now work as DMs to the other participant, allowing local agents to answer through
POST /v1/messages/:id/replies.dm_reply_not_participant); reactions remain refused.docs/contract.mdis updated.Written for commit b323cde. Summary will update on new commits.