Repository navigation
feat(settings): Replicas connection card with environment setup - #149
Merged
Merged
Conversation
Replace the generic remote-connection card for the Replicas provider with a card that drives the existing Control routes: connection status, the member responsible for Replicas agents (name and email so same-name members stay distinguishable), Apply Relay setup (set principal, then sync), per-environment opt-out, enable and retry, and the replica binding list with errors and message counts. The one-step flow is kept: the person pastes a Replicas API key and nobody handles a workspace key. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
[Medium impact] The PR appears safe to merge; both previous findings are addressed.
|
…ate with the connection form Control refuses every Replicas route to non-owner/admin members, so the setup panel now mounts only for managers and members see the owner/admin prompt whether or not a connection exists. The connection form and the setup panel share one busy signal: Disconnect/Replace are disabled while a setup write runs and setup writes are refused while the connection is being replaced or disconnected. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the generic remote-connection card for the Replicas provider with a dedicated settings card built on the existing Control routes. No new backend contract; the dashboard only reads and writes what Control already serves.
What the card shows
Name (email)so same-name members can be told apart, with "No default principal" and a disabled "Former member" option when the stored principal left. Apply Relay setup stores the choice and then runs an environment sync.Every write re-reads the policies and spawns, so a conflict leaves the newer server state on screen.
Files
src/admin/remote-agent-api.ts:replicasApi(workspace spawns, environment policies, sync, environment update, principal) with tolerant zod schemas (status strings open, unknown fields stripped).src/admin/replicas-settings.tsx: the card.src/admin/remote-agents.tsx,src/admin/settings.tsx: route thereplicasprovider to the new card and pass the organization id for the member list.src/admin/replicas-settings.test.tsx: six tests (responsible-member listing with duplicate names, apply then sync ordering, opt out / retry / enable writes, binding list with errors and counts, connect without leaking the key, non-manager view with no controls and no Replicas reads).Checks
npm run lint,vitest run src/admin/replicas-settings.test.tsx src/admin/remote-agents.test.tsx(25 passed) andnpm run buildall pass locally on this head.Opened with
merge-train:hold: no merge, image cut or deploy without a direct OK.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.