Skip to content

feat(relay-control): deployment default sharing mode and Control 0.5.35 (relay-control 0.4.23, agent-relay 0.7.68) - #474

Open
khaliqgant wants to merge 3 commits into
mainfrom
feat/control-sharing-mode
Open

khaliqgant wants to merge 3 commits into
mainfrom
feat/control-sharing-mode

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

What

  1. Deployment default session-sharing mode. Two optional values, unset by default, which keeps Control's built-in behaviour.
Value Env on the Control api container Accepted
sharing.defaultMode (relay-control.sharing.defaultMode under agent-relay) SELFHOST_DEFAULT_SHARING_MODE all, new, selected; empty = unset
sharing.overrideRoles SELFHOST_SHARING_MODE_OVERRIDE_ROLES (comma list) list from owner, admin; empty = unset

The render refuses any other mode, a non-list, an unknown role or a duplicate role. The chart default stays unset. owner,admin belongs only in the install values of the customer that asked for it.

  1. Control 0.5.35. This is the first image with relay-control#232. The chart default and the EKS, EKS RDS-native, GCP, gcp-proof-live and kind-core profiles move from 0.5.24 (sha256:d1b6ca95, edad643) to 0.5.35:
  • ghcr.io/agentworkforce/relay-control@sha256:1cb5bd714e7c9f326cfe107544b8b7125207c80a7e556ab8debf78a8b2167ad9, built from b985c6f by publish run 44492248387.
  • I verified it here:
    • gh attestation verify passes;
    • amd64 and arm64 pull anonymously;
    • the OCI revision label is b985c6f on both platforms;
    • the Cmd is unchanged (node node_modules/relay-control/dist/server.js).
  • Over 0.5.24, from layered-control's reading of the source diff:
    • migrations 0052-0065 and 0067-0077, with no operator step;
    • 0057 rewrites two small Desktop identity tables;
    • 0074 is a one-UPDATE backfill;
    • 0073 validates a constraint on admin_audit_events under a short lock;
    • no new required env or Secrets, and 20 new optional names.
  • History origins now live in SELFHOST_RELAYHISTORY_AUDIENCES. A History origin left in SELFHOST_INTROSPECT_AUDIENCES only produces a startup warning.
  • License: FSL-1.1-ALv2 from Control 0.5.28 on. Khaliq approved it for self-hosted distribution on 2026-11-19. The customer image record is updated.
  • No upgrade from a 0.5.24 database has been tested yet. Per Khaliq's direction, 0.5.35 goes to dev first.

Hold

merge-train:hold stays until 0.5.35 is proven in dev (infra-environments is preparing that pin) or Khaliq says to merge. This PR deploys nothing.

Changes

  • relay-control 0.4.23 and agent-relay 0.7.68 (lock), with main merged in at 0.7.67.
  • EKS Ingress controlPaths re-checked against the 0.5.35 source; the ten paths still cover it. New in 0.5.35: websocket GET /relay-node/v1/ws (under the existing /relay-node prefix) and Replicas/admin routes under /api/v1. This was a source read, not a live test, and the ALB idle timeout for the new websocket is unchecked.
  • Values, validation and env.
  • Profile pins.
  • Customer image record and release evidence hash.
  • Supply-chain doc.
  • Subdomain golden: only the Control digest and its hash-named migration Jobs move.
  • ci/control-sharing/test_chart.py.
  • Registry option opt.relay-control.sharing-mode.

Checks run locally

  • control-sharing, control-analytics, native-no-relayauth, native-history-connection, release-candidate, control-webapp-names and history-upload: pass.
  • Customer release gate tests: PASS (38 cases).
  • Registry check: OK.
  • Subdomain golden: OK.
  • Version bump check: OK.
  • helm lint: OK.

🤖 Generated with Claude Code

@khaliqgant khaliqgant added the merge-train:hold Do not merge without Khaliq's direct OK label Nov 18, 2026
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

Walkthrough

The relay-control chart adds optional sharing settings, validates their values, and renders corresponding environment variables. Agent Relay advances its chart and Control image pins. Tests, compatibility records, and self-hosted release evidence are updated.

Changes: Control Sharing and Release

Layer / File(s) Summary
Sharing settings in the chart
charts/relay-control/templates/_helpers.tpl, charts/relay-control/values.yaml, charts/relay-control/templates/deployment.yaml
The chart adds optional sharing.defaultMode and sharing.overrideRoles settings. It validates supported values and renders the corresponding environment variables when configured.
Sharing chart test coverage
ci/control-sharing/test_chart.py, .github/workflows/fast-path.yml, .github/workflows/lint.yml
New chart-rendering tests cover unset and configured values, invalid values, protected extraEnv names, and umbrella-chart rendering. Both workflows add the test command.
Release pins and compatibility records
charts/agent-relay/Chart.yaml, charts/agent-relay/values-*.yaml, charts/relay-control/Chart.yaml, charts/relay-control/README.md, ci/agent-relay/*, docs/self-hosted-image-supply-chain.md, docs/self-hosted-requirements.md, self-hosted/customer-images.yaml, self-hosted/customer-release-evidence.json, self-hosted/requirements.yaml
Agent Relay and relay-control chart versions and Control image pins advance to the updated release. Image hashes, compatibility entries, release metadata, license records, and supply-chain evidence are updated.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Possibly related issues

  • AgentWorkforce/infra#77: This PR updates the Control image pin in the kind-core profile, but does not add the kind-up or proof tooling described by the issue.

Suggested reviewers: miyaontherelay, kjgbot

Merge Risk: Minimal · up to cea64

The change adds optional, unset-by-default session-sharing settings and moves Control to 0.5.35. The chart validates its inputs and reserves the generated variable names. No concrete merge-blocking defect was established. The author says the image is intended for dev first, and compatibility with the new History audience variable should be confirmed there.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title names the main change: a deployment default session-sharing mode for relay-control, plus the Control 0.5.35 image bump and chart versions. The raw summary confirms the chart values, helper v…
Description check Passed The description is closely related to the changeset. It documents the sharing.defaultMode and sharing.overrideRoles values and their env variables, the Control 0.5.35 image pin across profiles, the mi…
Full details: Title check

Explanation

The title names the main change: a deployment default session-sharing mode for relay-control, plus the Control 0.5.35 image bump and chart versions. The raw summary confirms the chart values, helper validation, deployment env wiring, and profile pin updates that match this title. The title is long (114 characters) but remains specific and on-topic.

Full details: Description check

Explanation

The description is closely related to the changeset. It documents the sharing.defaultMode and sharing.overrideRoles values and their env variables, the Control 0.5.35 image pin across profiles, the migrations and license changes, the supply-chain and release-evidence updates, the new test_chart.py suite, and the registry option. This matches the file-level summaries.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the chart at dawn,
New sharing values hop along.
The defaults rest, unset and still,
While chosen roles pass every test.
New pins arrive with records clear,
And carrots mark the release near.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T19:38:32.167076Z e419b1d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[High impact] No new blocking code issue was established; keep the stated dev-proof hold before merging.

Summary

Adds optional deployment-wide sharing settings and pins Control 0.5.35 across the chart default and five profiles.

  • Control deployments can set sharing defaults and who may change them.
  • Self-hosted Control charts now pin version 0.5.35.

Reviews (5) · Last reviewed commit: "merge main into feat/control-sharing-mod..." · Reviewed by Greptile

@khaliqgant
khaliqgant force-pushed the feat/control-sharing-mode branch from e419b1d to c16b1cd Compare November 19, 2026 10:24
@khaliqgant khaliqgant changed the title feat(relay-control): deployment default session-sharing mode (0.4.23, agent-relay 0.7.58) feat(relay-control): deployment default sharing mode and Control 0.5.35 (relay-control 0.4.23, agent-relay 0.7.62) Nov 19, 2026
Comment thread docs/self-hosted-image-supply-chain.md Resolved
@khaliqgant khaliqgant added merge-train:hold Do not merge without Khaliq's direct OK and removed merge-train:hold Do not merge without Khaliq's direct OK labels Nov 19, 2026
khaliqgant and others added 2 commits November 19, 2026 07:37
…35 (relay-control 0.4.23, agent-relay 0.7.62)

- sharing.defaultMode (unset by default): all, new or selected, renders
  SELFHOST_DEFAULT_SHARING_MODE on the Control api container.
- sharing.overrideRoles (empty by default): list from owner and admin, renders
  SELFHOST_SHARING_MODE_OVERRIDE_ROLES as a comma list.
- Render refuses any other mode, a non-list, an unknown role or duplicates,
  matching Control's own startup refusal.
- The chart default and the EKS, EKS RDS-native, GCP, gcp-proof-live and
  kind-core profiles move to relay-control 0.5.35 (sha256:1cb5bd71, b985c6f,
  publish run 44492248387; GitHub build-provenance attestation verified;
  amd64+arm64 verified anonymously). It is the first image with #232. Over
  0.5.24: migrations 0052-0077 with no operator step, no new required env,
  same Cmd. License FSL-1.1-ALv2 from 0.5.28, approved by Khaliq 2026-11-19.
- customer-images relay-control entry, release evidence manifest hash,
  supply-chain doc and the subdomain golden follow; the golden diffs are the
  Control digest and its hash-named migration Jobs.
- ci/control-sharing/test_chart.py; registry option
  opt.relay-control.sharing-mode.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… names 0.5.35

- Type-check sharing.defaultMode / overrideRoles before any default, so false, 0
  and {} are refused instead of silently treated as unset; sharing must be a map.
- Reserve SELFHOST_DEFAULT_SHARING_MODE and SELFHOST_SHARING_MODE_OVERRIDE_ROLES
  so extraEnv cannot duplicate or shadow them; tests for both.
- docs/self-hosted-image-supply-chain.md: the relay-control row now names 0.5.35
  (b985c6f, run 44492248387, FSL-1.1-ALv2), attestation re-verified.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@khaliqgant khaliqgant changed the title feat(relay-control): deployment default sharing mode and Control 0.5.35 (relay-control 0.4.23, agent-relay 0.7.62) feat(relay-control): deployment default sharing mode and Control 0.5.35 (relay-control 0.4.23, agent-relay 0.7.64) Nov 19, 2026
@khaliqgant
khaliqgant force-pushed the feat/control-sharing-mode branch from 199d1c6 to 6bfaf1b Compare November 19, 2026 15:38
Resolve the six conflicting files so both sides survive:
- charts/agent-relay/Chart.yaml: version 0.7.68 (next after main's 0.7.67),
  relay-control dependency 0.4.23, everything else from main.
- charts/agent-relay/Chart.lock: regenerated with helm v4.3.1 (lint.yml
  HELM_VERSION); only relay-control, digest and generated move.
- ci/agent-relay/subdomain-golden.sha256: regenerated with
  ci/agent-relay/subdomain-golden.sh update.
- self-hosted/requirements.yaml: main's 0.7.63/0.7.66/0.7.67 entries kept,
  0.7.67 demoted to planned; the PR's entry becomes agent-relay-0.7.68 on
  main's pins (sessions-pipeline 0.8.52, relay-webapp 0.2.8) plus
  relay-control 0.4.23 / Control 0.5.35.
- docs/self-hosted-requirements.md: regenerated with registry.mjs render.
- self-hosted/customer-release-evidence.json: main's side with
  imageManifestSha256 set to the merged customer-images.yaml hash.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

charts/relay-control/templates/_helpers.tpl: 1

68-80: Trivial · Maintainability & Code Quality · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Declare the sharing input constraints in values.schema.json.

Move the field types, allowed values and role uniqueness into a schema. This makes the configuration contract declarative and lets Helm validate it before template rendering, including through the umbrella chart. Preserve the current unset/null behavior. Keep the extraEnv ownership checks in the helper. Helm supports chart and subchart value schemas. (helm.sh)

Update the refusal tests to match schema diagnostics.

Based on learnings, prefer declarative values.schema.json validation over template-level fail checks.

Source: Learnings

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b0226f42-0719-460f-b692-703ddf4ca5a0
Commits

Reviewing files that changed from the base of the PR and between c43b0d1 and cea64b2.

Files ignored due to path filters: 1

  • charts/agent-relay/Chart.lock is excluded by !**/*.lock
Files selected for processing: 21

  • .github/workflows/fast-path.yml
  • .github/workflows/lint.yml
  • charts/agent-relay/Chart.yaml
  • charts/agent-relay/values-eks-rds-native.yaml
  • charts/agent-relay/values-eks.yaml
  • charts/agent-relay/values-gcp-proof-live.yaml
  • charts/agent-relay/values-gcp.yaml
  • charts/agent-relay/values-kind-core.yaml
  • charts/relay-control/Chart.yaml
  • charts/relay-control/README.md
  • charts/relay-control/templates/_helpers.tpl
  • charts/relay-control/templates/deployment.yaml
  • charts/relay-control/values.yaml
  • ci/agent-relay/subdomain-golden.sha256
  • ci/agent-relay/test_native_no_relayauth.py
  • ci/control-sharing/test_chart.py
  • docs/self-hosted-image-supply-chain.md
  • docs/self-hosted-requirements.md
  • self-hosted/customer-images.yaml
  • self-hosted/customer-release-evidence.json
  • self-hosted/requirements.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@khaliqgant

Copy link
Copy Markdown
Member Author

Merge commit cea64b2 merges main (c43b0d1) into this branch. It is a plain merge with no rebase and no force push. It resolves the six conflicting files and changes no behaviour:

  • charts/agent-relay/Chart.yaml: version 0.7.68 (the next one after main's 0.7.67). The relay-control dependency stays at this PR's 0.4.23. Everything else comes from main.
  • charts/agent-relay/Chart.lock: regenerated with helm dependency update on Helm v4.3.1 (the version lint.yml pins). Against main, only the relay-control entry, the digest and the generated timestamp change.
  • ci/agent-relay/subdomain-golden.sha256: regenerated with ci/agent-relay/subdomain-golden.sh update.
  • self-hosted/requirements.yaml: main's 0.7.63, 0.7.66 and 0.7.67 entries are kept, and 0.7.67 is now planned. This PR's entry becomes agent-relay-0.7.68 (current, unreleased). It uses main's pins (sessions-pipeline 0.8.52, relay-webapp 0.2.8) plus relay-control 0.4.23 / Control 0.5.35. opt.relay-control.sharing-mode is kept.
  • docs/self-hosted-requirements.md: regenerated with node ci/self-hosted-requirements/registry.mjs render.
  • self-hosted/customer-release-evidence.json: taken from main, with imageManifestSha256 set to the hash of the merged customer-images.yaml.

No 0.7.64 is left anywhere in the tree. git diff origin/main...HEAD lists the same 22 files as before the merge. Of those, only the six above differ from this PR's own changes.

Local checks, all on Helm v4.3.1 and all passing:

  • scripts/ci/charts.sh static, ci/agent-relay/render.sh, scripts/ci/deps.sh, ci/actors-s3/render.sh
  • registry.mjs check, ci/self-hosted-requirements/test.sh, plus the render followed by git diff --exit-code
  • ci/customer-release-gate/test.py, validate-customer-release.py --consistency
  • scripts/ci/version-bump.sh origin/main, subdomain-golden.sh check, make local-acceptance-test
  • every Python test in lint.yml's static job, including ci/control-sharing/test_chart.py and ci/agent-relay/test_eks_alb_ingress.py

Two native tests check file modes, and they need the CI umask of 022.

I also rendered helm template with values-eks.yaml. With sharing set, SELFHOST_DEFAULT_SHARING_MODE and SELFHOST_SHARING_MODE_OVERRIDE_ROLES reach the Control api container; with sharing unset, neither is rendered. With eksIngress enabled (example domain, placeholder ARN), the ALB Ingress renders with the ten default control paths.

The PR's checks are green on cea64b2. The title and body still say 0.7.64; they are left for the owner's steward to update.

@khaliqgant khaliqgant changed the title feat(relay-control): deployment default sharing mode and Control 0.5.35 (relay-control 0.4.23, agent-relay 0.7.64) feat(relay-control): deployment default sharing mode and Control 0.5.35 (relay-control 0.4.23, agent-relay 0.7.68) Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-train:hold Do not merge without Khaliq's direct OK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant