Skip to content

Stop committing Cargo.lock #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdaWorldAPI merged 6 commits into from
Sep 4, 2026
Merged

Stop committing Cargo.lock #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4f12e2
Stop committing Cargo.lock
claude Sep 4, 2026
14e3689
Revert "Stop committing Cargo.lock"
claude Sep 4, 2026
f134c07
Pin the ndarray fork's current revision and catch future drift
claude Sep 4, 2026
2de029f
Stop committing Cargo.lock
claude Sep 4, 2026
1325019
Drop --locked from the release binary build
claude Sep 4, 2026
eea7203
Merge remote-tracking branch 'origin/main' into claude/atlas-spatial-…
claude Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
# dependency graph into the binary so consumers can recover
# the SBOM directly from the binary via `cargo audit bin`.
cargo install --locked cargo-auditable --version 0.7.0
cargo auditable build --target ${target} --release -p tract-cli --locked
cargo auditable build --target ${target} --release -p tract-cli
mkdir tract-$name
cp target/${target}/release/tract tract-${name}
tar czf tract-${name}.tgz tract-${name}
Expand Down
6 changes: 6 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,9 @@ proptest-regressions
wheelhouse
target-bisector*
/nvidia

# Cargo.lock is not committed in this fork: the workspace consumes the
# AdaWorldAPI/ndarray fork by git branch, and a committed lock pins a stale
# revision of it (measured: the lock held ndarray e55af0e3 while the branch
# was at f43338fb, so builds silently used a two-merge-old dependency).
Comment on lines +26 to +27

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove historical state from the ignore comment

The recorded commit IDs and “two-merge-old” measurement describe a one-time repository state rather than the current contract; as soon as the branch advances, this explanation becomes stale while remaining in the configuration. State the durable reason for the ignore rule without narrating the prior lock contents.

AGENTS.md reference: AGENTS.md:L272-L272

Useful? React with 👍 / 👎.

Cargo.lock

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the moving git dependency from becoming silently pinned

On any persistent developer checkout, the first Cargo command recreates this ignored Cargo.lock, and subsequent builds continue honoring the git revision recorded there rather than refreshing the master branch. This therefore fixes the stale ndarray revision only once and then recreates the same stale-branch problem invisibly—git status will not expose it—so experiments intended to exercise later fork changes can silently run older code unless the developer explicitly deletes the lock or runs cargo update.

Useful? React with 👍 / 👎.

Loading
Loading