Skip to content

Synergy map revision after #385–#393 and lance-graph #1847–#1848 - #394

Merged
AdaWorldAPI merged 1 commit into
masterfrom
ccr-45a41fb4-0j3i0l
Oct 29, 2026
Merged

Synergy map revision after #385–#393 and lance-graph #1847–#1848#394
AdaWorldAPI merged 1 commit into
masterfrom
ccr-45a41fb4-0j3i0l

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Oct 29, 2026

Copy link
Copy Markdown
Owner

What

Adds section R2 to .claude/knowledge/synergy-map-2026-10-29.md. R2 updates the first pass's rows against ndarray master 870e733 and lance-graph main 61720fa. The change is documentation only.

Rows that changed

  • H1 (parity coverage for the 16 facade types): partly closed by Complete the U16x32 facade surface on every backend #385. The first parity test for U16x32 found two existing AVX-512 bugs: shl/shr returned 0 for most shift counts, and pack_saturate_u8 used packus_epi16.
  • H3 (AVX2 popcount): reframed. On AVX2, u64::count_ones compiles to the same vpshufb nibble table. Rewriting the 7 R1 hits that way would hide them from the source-level guard and change nothing in the machine code.
  • AVX2 U8x64::mask_blend is now R2 burn-down item Add comprehensive rustynum vs ndarray comparison with benchmarks #1. The measurements put it first: 75–81 ns per 64 values against 10 ns.

New findings

  • N10: the two 9-bit contracts (Arithmetic511 and Codebook512) are kept apart consistently in both repos.
  • N11: recall (lance-graph) and cost (ndarray) were measured on different layouts. No one has measured recall for the stored SM9 grid.
  • N12: on AVX2 the masked byte-dot compiles to vpshufb, which the source guard cannot see. The proposed check belongs in codegen-witness.sh.
  • N13: the ndarray half of lance-graph's W4 shipped in Add I32x16::dot4_u8_i8_add and the U8x64 nibble split on every backend #386.
  • N14: the U8→I8 bit view and the R3 rule need one ruling.
  • N15: CI does not run the NEON or wasm library tests.

Checks

  • The facet-stride count was re-taken: 166, unchanged.
  • The guard passes on this diff.

Generated by Claude Code

@claude
knowledge: revise synergy map after #385-#393 and lance-graph #1847-#…
7100daf 
…1848

Adds section R2. Rows moved: H1 partly closed by #385 (first U16x32
parity found two AVX-512 bugs); H3 reframed (count_ones lowers to the
same vpshufb nibble table on AVX2, so a rewrite would only hide it);
AVX2 mask_blend set as R2 burn-down item #1 by measurement. New dots
N10-N15: the two 9-bit contracts agree across repos; recall and cost
were measured on different layouts; the AVX2 masked dot hides
compiler-emitted shuffles the source guard cannot see; W4's ndarray
half shipped in #386; the u8->i8 view and R3 are one ruling; NEON and
wasm lib tests are not in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XAqKMPh2Seh2WLccCksAdY
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1f10800a-5537-4f97-a184-7a1ac8f0a63c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 29, 2026 23:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T23:37:17.881108Z 7100daf Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit 18699f1 into master Oct 29, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdaWorldAPI @claude