Skip to content

Stop committing Cargo.lock - #300

Merged
AdaWorldAPI merged 1 commit into
masterfrom
claude/atlas-spatial-hydration-fp4dyc
Sep 4, 2026
Merged

Stop committing Cargo.lock#300
AdaWorldAPI merged 1 commit into
masterfrom
claude/atlas-spatial-hydration-fp4dyc

Conversation

@AdaWorldAPI

@AdaWorldAPI AdaWorldAPI commented Sep 4, 2026

Copy link
Copy Markdown
Owner

What

Removes Cargo.lock, crates/burn/Cargo.lock, and crates/wasm-simd-parity/Cargo.lock from the repo, and ignores Cargo.lock.

Why

This crate is consumed by sibling repos (tract, lance-graph) as a git dependency, so a downstream build never reads the committed lock — it resolves against the branch. The lock therefore describes nothing a consumer uses and only drifts against the branch it claims to describe.

That drift was measured rather than assumed: tract's own committed lock pinned this crate at e55af0e3 (PR #297) while origin/master was already at f43338fb (PR #299), so tract was building against a revision two merges behind — one that predates the #299 AVX-512 test-blind-spot fix. Removing the locks on both sides makes the branch pin mean what it says.

Verification

cargo metadata --format-version 1 completes with no lock present. Working tree clean; no source file touched.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QDLGAoWFEqDqUiHJGgNvuu


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Added repository configuration to exclude the Rust lockfile for this library project.

This is a library crate consumed by sibling repos (tract, lance-graph) as a git dependency, so the committed lock is never used by a downstream build and only drifts against the branch it claims to describe. Removing it and ignoring it; verified the workspace still resolves.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QDLGAoWFEqDqUiHJGgNvuu
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 3f7c2336-96f1-4476-beb5-f19a3aed6f97

📥 Commits

Reviewing files that changed from the base of the PR and between f43338f and ae9866b.

⛔ Files ignored due to path filters (3)
  • Cargo.lock is excluded by !**/*.lock
  • crates/burn/Cargo.lock is excluded by !**/*.lock
  • crates/wasm-simd-parity/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .gitignore

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The .gitignore file now excludes Cargo.lock and documents that the repository is a library crate consumed through Git dependencies.

Changes

Cargo lockfile handling

Layer / File(s) Summary
Document and ignore Cargo.lock
.gitignore
Comments explain why Cargo.lock is not committed. The file is added to the ignored paths.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ae986

This change removes committed Cargo lockfiles and ignores future lockfiles for the library workspace. The current change is ready to merge with no identified user or production risk.

Poem

A rabbit checks the ignore list,
Cargo’s lockfile will not persist.
Five new lines mark the way,
For library builds each day.
Hop, commit, and keep it clean!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: stop committing Cargo.lock files. It matches the removal and ignore configuration updates described in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 4, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_27187b08-a6bc-4bc5-8165-5284e9ec1f83)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 4, 2026 18:17
@AdaWorldAPI
AdaWorldAPI merged commit fe509db into master Sep 4, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants