Stop committing Cargo.lock - #300
Conversation
This is a library crate consumed by sibling repos (tract, lance-graph) as a git dependency, so the committed lock is never used by a downstream build and only drifts against the branch it claims to describe. Removing it and ignoring it; verified the workspace still resolves. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QDLGAoWFEqDqUiHJGgNvuu
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe ChangesCargo lockfile handling
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes committed Cargo lockfiles and ignores future lockfiles for the library workspace. The current change is ready to merge with no identified user or production risk. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_27187b08-a6bc-4bc5-8165-5284e9ec1f83) |
What
Removes
Cargo.lock,crates/burn/Cargo.lock, andcrates/wasm-simd-parity/Cargo.lockfrom the repo, and ignoresCargo.lock.Why
This crate is consumed by sibling repos (tract, lance-graph) as a git dependency, so a downstream build never reads the committed lock — it resolves against the branch. The lock therefore describes nothing a consumer uses and only drifts against the branch it claims to describe.
That drift was measured rather than assumed: tract's own committed lock pinned this crate at
e55af0e3(PR #297) whileorigin/masterwas already atf43338fb(PR #299), so tract was building against a revision two merges behind — one that predates the #299 AVX-512 test-blind-spot fix. Removing the locks on both sides makes the branch pin mean what it says.Verification
cargo metadata --format-version 1completes with no lock present. Working tree clean; no source file touched.🤖 Generated with Claude Code
https://claude.ai/code/session_01QDLGAoWFEqDqUiHJGgNvuu
Generated by Claude Code
Summary by CodeRabbit