Post-merge records for #1217 - #1219
Conversation
Not hygiene-only, so the termination clause does not apply: #1217 landed a plan (the recovered SPEC v1) and a finding (the reset/empty-range rule). Both are things a future session would need the why for, which is the rule's actual test. The arc entry carries what the PR cost and what it bought: the orphaning mechanism and the check that certified it; the retraction of #1201's own "merged MIXED" self-correction; the three append-only readings adjudicated when two review bots asked for opposite changes on the same line; and the miss worth more than the fix — one fact in three files, two updated, because I was correcting whichever file each finding pointed at. Also banked for whoever rules the still-held F5 VIOLATES: the wave.abi path reads gz-TSV sidecar HashMaps, not the declared edge_lanes slab and not DataFusion. E-EVERY-DOMAIN-IS-A-TABLE-AND-A-CROSSWALK-IS-A-CHAIN-OF-MASKS-1, merged into this branch from #1218, names that class from the other end and cites obo_store.rs among its six sites — so the specific case has a general ruling now, though whether it discharges F5 is still the operator's call. Branch restarted from origin/main with the check the finding prescribes: `git merge-base --is-ancestor` confirmed the tip was fully merged BEFORE the reset, rather than reading an empty `origin/main..branch` after one. Supersession index regenerated after the board writes; byte-identical. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EfrUJH3UNnv5NpDH4jDGHq
|
Warning Review limit reachedNext included review available in 28 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 55 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d99c1226-4dd1-411c-8394-fe3b7cee0d28) |
Board hygiene for #1217 (
b518dbf1). No code, no schema, no Cargo change.Why this PR exists at all
#1217 was not hygiene-only — it landed a plan (the recovered SPEC v1) and a finding (
E-AN-EMPTY-RANGE-AFTER-A-RESET-IS-NOT-EVIDENCE-1). The termination clause exempts a PR whose entire content is records for prior PRs; this one had content a future session needs the "why" for, so it owes an arc entry and aLATEST_STATErow.This PR, by contrast, is hygiene-only, so the chain stops here.
What the entry records
git checkout -B <branch> origin/mainwhile unmerged, and the check meant to prevent that —git log origin/main..<branch>— returned EMPTY by construction, because an earlier reset had already re-pointed the branch. The symptom of the loss is indistinguishable from the all-clear. Correct check:git merge-base --is-ancestor, or the reflog.CLAUDE.mdwhen two review bots asked for opposite changes on the same line:LATEST_STATEdated sections are historical (restore + prepend);PR_ARC_INVENTORYhas its own narrower rule ("corrections append as new dated lines");STATUS_BOARDis a live dashboard with an in-place lifecycle. CodeRabbit withdrew both findings it had raised against the latter two.D-NGN-AUDITlives in three files and the first pass updated two — because I was correcting whichever file each finding pointed at. A finding names a symptom; the fact has to be chased to every record that states it.Still open, and deliberately not acted on
D-NGN-AUDITremains HELD at Phase 2 on the F5 VIOLATES — the operator's to rule.Banked for whoever rules it: the
wave.abipath reads gz-TSV sidecar HashMaps (obo_full_edges,obo_ro_edges), not the declarededge_lanesslab and not DataFusion.E-EVERY-DOMAIN-IS-A-TABLE-AND-A-CROSSWALK-IS-A-CHAIN-OF-MASKS-1(operator-ruled, #1218) names that class from the other end — something decided once upstream, re-derived at read time, per row — and citesobo_store.rsamong its six sites. Whether that discharges F5 or merely re-describes it is not mine to decide.Also flagged: SPEC §2's
canonical_node.rsline numbers are stale after themint_forV2/V3 drift, so Phase 3 should not be cast against v1 as written.Method note
The branch was restarted from
origin/mainusing the check the finding itself prescribes —git merge-base --is-ancestorconfirmed the tip was fully merged before the reset, rather than reading an empty range after one.Supersession index regenerated after the board writes; byte-identical.
🤖 Generated with Claude Code
https://claude.ai/code/session_01EfrUJH3UNnv5NpDH4jDGHq
Generated by Claude Code