Bump Rust toolchain to 1.98.1 - #299
Conversation
Updates rust-toolchain.toml and the CI workflow's pinned toolchain from 1.97.1 to 1.98.1, and fixes the three clippy findings the bump surfaces under `-D warnings`: - ogar-a2ui-frame: chunks_exact(8).map(u64::from_le_bytes([..])) is now clippy::chunks_exact_to_as_chunks; rewritten to as_chunks::<8>().0.iter().map(u64::from_le_bytes). - ogar-r2il example: a doc-comment list continuation line was over-indented (4 spaces instead of 2), newly caught by clippy::doc_overindented_list_items. - ogar-dismech: a deliberately-runtime named test asserting bounds on a `pub const` now trips clippy::assertions_on_constants; allowed explicitly with a comment, since the intent is a documented cargo-test invariant, not a compile-time const assertion. rust-version in the workspace Cargo.toml is left at 1.95 — it already diverges from the toolchain channel in this repo's history (channel was 1.97.1) and no rule ties the two together. Verified with bare `cargo` (no +toolchain): `cargo check --workspace --all-targets`, `cargo test --workspace` (847 passed, 0 failed), the five feature-gated CI test steps, `cargo clippy --workspace --all-targets -- -D warnings` (clean), and `cargo fmt --check` (clean). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_90b20073-1155-43be-a79d-2082652f6758) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (4)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe PR updates the Rust toolchain to 1.98.1, changes ChangesRust maintenance
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The repository and CI toolchains now use Rust 1.98.1, while frame mask decoding retains little-endian u64 behavior with fixed-size byte chunks. No current merge-blocking production or user-impact risk is identified. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
clippy::assertions_on_constants is NOT new in 1.98 — checked against the clippy changelog, it is not in the 1.98 list at all, and the neighbouring doc_overindented_list_items dates to 1.86. Both surfaced here only because OGAR has no clippy job in CI (ci.yml runs check + test only), so -D warnings had effectively never run in this repo. So this allow was silencing a pre-existing lint inside a toolchain-bump PR, which hides a real signal rather than fixing it, and does so for a lint nothing in this repo currently checks. The backlog belongs to whatever PR adds the clippy gate, where the whole policy gets decided at once. The one-character doc-comment dedent is kept: it FIXES its lint rather than masking it, and reverting a correct whitespace change would be churn. Verified after the revert: cargo test -p ogar-dismech --lib exit 0, 20 passed 0 failed; cargo fmt --check clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 participants
What
rust-toolchain.tomlchannel1.97.1→1.98.1, plus the one genuine CI pin (.github/workflows/ci.ymltoolchain:). Part of the workspace-wide sweep to current stable (1.98.0 released 2026-08-20, 1.98.1 on 2026-09-01).Findings, correctly classified
⊘ An earlier version of this description called all three findings "1.98 findings". That was wrong and is corrected here. Checked against the clippy changelog:
clippy::chunks_exact_to_as_chunkscrates/ogar-a2ui-frame/src/lib.rs:248stylegroupclippy::doc_overindented_list_itemscrates/ogar-r2il/examples/probe_counterfactual_witness_kernel.rs:48clippy::assertions_on_constantscrates/ogar-dismech/src/lib.rs:835/840The more interesting finding: OGAR has no clippy gate
The two misattributed lints did not appear because the toolchain moved. They appeared because
.github/workflows/ci.ymlruns onlycheckandtest— there is no clippy or fmt job in this repo at all, so-D warningshad effectively never run here. Every sibling repo in the sweep gates clippy in CI; OGAR is the exception, and that is why it carries a lint backlog spanning several releases.That is worth its own decision (add a clippy job, then burn down whatever it surfaces) and is deliberately not bundled into a toolchain bump.
Also reported, not fixed
cargo clippy -p ogar-adapter-surrealql --features surrealdb-parsersurfaces 2 pre-existingclippy::bool_comparisonfindings (src/lib.rs:1053,:1130). CI'steststep exercises that feature but no clippy job checks it. Left out of scope.Verification
All bare
cargoon the new pin (provingrust-toolchain.tomlresolves without+toolchain), all withCARGO_PROFILE_DEV_DEBUG=0 CARGO_INCREMENTAL=0:cargo check --workspace --all-targets→ exit 0cargo test --workspace→ exit 0, 847 passed, 0 failed across 84 groupscargo clippy --workspace --all-targets -- -D warnings→ exit 0 after the fixes (not a CI step here; run because that is where the lint delta lives)cargo fmt --check→ exit 0Cargo.toml'srust-version = "1.95"left unchanged: this repo's history shows the channel already diverged from it with no stated rule tying them together.🤖 Generated with Claude Code
https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V
Summary by CodeRabbit
Bug Fixes
Documentation
Chores