fix: rename RethNodeDown alert to AbstractExternalNodeDown - #36
Open
Sertug17 wants to merge 1 commit into
Open
Conversation
The default PrometheusRule alert was named RethNodeDown with summary and description referencing 'Reth Node'. Abstract runs a zkSync-based external node (matterlabs/external-node), not Reth. This was a copy-paste artifact from a Reth-based chart template. Rename the alert and update annotations to correctly reference the Abstract External Node. Fixes Abstract-Foundation#34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34
The default PrometheusRule alert is named
RethNodeDownwith annotations referencing "Reth Node". Abstract is a zkSync-based L2 runningmatterlabs/external-nodenot Reth. This was a copy-paste artifact from a Reth-based chart template.Renames the alert and updates summary/description annotations to correctly reference the Abstract External Node.
PR-Codex overview
This PR modifies the alert configuration in the
prometheusrules.yamlfile for a monitoring system. It changes the alert name and updates the summary and description to reflect a new context related to an external node.Detailed summary
RethNodeDowntoAbstractExternalNodeDown.Reth Node {{ printf "{{ $labels.instance }}" }} downtoAbstract External Node {{ printf "{{ $labels.instance }}" }} down.Reth Node {{ printf "{{ $labels.instance }}" }} is downtoAbstract External Node {{ printf "{{ $labels.instance }}" }} is down.