fix: add missing consensus-config ConfigMap volume to StatefulSet - #35
Open
Sertug17 wants to merge 1 commit into
Open
fix: add missing consensus-config ConfigMap volume to StatefulSet#35Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
When consensus.enabled is true, the StatefulSet mounts a volume named consensus-config but no corresponding volume is defined. This causes pod creation to fail with 'volume consensus-config not found'. The consensus ConfigMap is already created by configmap-consensus.yaml but was never referenced as a volume source in the StatefulSet. Add the ConfigMap volume above the persistence check so it is available in both persistent and non-persistent modes. Fixes Abstract-Foundation#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When consensus.enabled is true, the StatefulSet mounts a volume named consensus config but no corresponding volume is defined. This causes pod creation to fail with 'volume consensus-config not found'.
The consensus ConfigMap is already created by configmap consensus.yaml but was never referenced as a volume source in the StatefulSet.
Add the ConfigMap volume above the persistence check so it is available in both persistent and non-persistent modes.
Fixes #33
PR-Codex overview
This PR focuses on adding a new volume configuration for a
consensus configin thestatefulset.yamltemplate, contingent on theconsensus.enabledvalue. It also removes thestatekeepervolume when persistence is not enabled.Detailed summary
consensus configthat uses aconfigMap.consensus-configvolume is conditionally included based on.Values.consensus.enabled.statekeepervolume definition when persistence is not enabled.