fix(examples): derive tool dispatch names from manifest (#178) - #329
Merged
Conversation
Replace hardcoded skill IDs in claude_tos_evaluator, ollama_tos_evaluator, and ollama_novelty_extractor with manifest-derived TOOL_NAME values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #178
Replace hardcoded skill IDs in agent-loop examples with manifest-derived
TOOL_NAMEvalues so dispatch stays aligned with the loaded bundle if manifest names change.Changes:
examples/claude_tos_evaluator.py—TOOL_NAME = bundle["manifest"]["name"]; dispatch viatool_name == TOOL_NAMEexamples/ollama_tos_evaluator.py— same pattern; Ollama JSON template uses{TOOL_NAME}instead of"the_tool_name"examples/ollama_novelty_extractor.py— same Ollama patternCHANGELOG.md—[Unreleased]Fixed entryexamples/gemini_tos_evaluator.pywas already correct on main (sanitized manifest name). No loader, skill, or index changes.Type of Change
Checklist (all PRs)
Fixes #178)black --check/flake8on touched files (examples-only diff)pytest tests/test_registry_docs.pyandtests/test_examples_smoke.py— 19 passedCHANGELOG.mdupdated under[Unreleased]examples/README.mdunchanged (no scripts added/renamed/removed)pytest tests/test_registry_docs.pyrun (no catalog/agent-loops matrix change)New or updated skill
N/A — examples-only PR.
Related Issues
Fixes #178