-
Notifications
You must be signed in to change notification settings - Fork 15
Feat/minor improvements #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2.2.0 | ||
| 2.2.1 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -280,15 +280,14 @@ function SupportUsButton( | |
| </svg> | ||
| </span> | ||
| <h1 className="min-w-0 font-medium text-3xl sm:text-3xl md:text-5xl leading-tight tracking-tight text-center"> | ||
| Support-us {projectInformation?.name && "and"}{" "} | ||
| {projectInformation?.name} | ||
| Support {" "}{projectInformation?.name} | ||
| </h1> | ||
| </div> | ||
| {projectInformation?.name && ( | ||
| <div> | ||
| <span className="text-lg sm:text-base md:text-xl leading-snug flex flex-wrap justify-center items-center gap-1"> | ||
| <p className="italic"> | ||
| A Project Powered by | ||
| <p> | ||
| A project made by | ||
|
Comment on lines
+289
to
+290
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Use phrasing content for the attribution label.
As per path instructions, the JSX must follow React best practices. 🤖 Prompt for AI AgentsSource: Path instructions |
||
| </p> | ||
| {validatedUrl ? ( | ||
| <a | ||
|
|
@@ -386,11 +385,14 @@ function SupportUsButton( | |
| height="62" | ||
| viewBox="0 0 62 62" | ||
| fill="none" | ||
| className="w-[clamp(1.5rem,3.5vw,2.75rem)] h-[clamp(1.5rem,3.5vw,2.75rem)] flex-none" | ||
| className="w-[clamp(1.5rem,3.5vw,2.75rem)] h-[clamp(1.5rem,3.5vw,2.75rem)] overflow-visible" | ||
| > | ||
| <path | ||
| d="M35.431 0C39.6228 8.98514 51.2756 26.334 61.8182 26.334V35.4842H61.7276C47.2295 35.4842 35.431 47.2982 35.431 61.8182H26.29V61.8117C26.29 48.5541 33.5892 36.9699 44.3778 30.8816C40.0924 28.447 34.1734 20.7486 31.2286 16.7965C32.3689 14.2417 32.9599 13.6397 33.9892 10.0793M35.431 0C35.431 9.48036 31.7474 18.3846 25.0503 25.0911C22.7914 27.358 20.2371 29.3101 17.4566 30.8945C21.7293 33.3253 27.4488 41.3542 30.3815 45.2706C28.7626 48.7871 27.3396 58.2747 26.29 61.8182C22.2439 53.2247 11.1964 35.9179 1.20736 35.4648C0.803828 35.4777 0.401375 35.4842 0 35.4842V26.2822C0.405691 26.2822 0.808144 26.2887 1.20736 26.3016C7.76299 26.0151 13.9707 23.272 18.596 18.6176C21.0456 16.1771 22.9869 13.275 24.3076 10.0793C25.6283 6.88363 26.3021 3.45778 26.29 0H35.431Z" | ||
| fill="currentColor" | ||
| d="M24.5 37.5L37.5 24.5M19.2 42.8L14.5 47.5C10.4 51.6 3.7 51.6 0 47.9C-3.7 44.2 -3.7 37.5 0.4 33.4L14.2 19.6C18.3 15.5 25 15.5 29.1 19.6L31.5 22M42.8 19.2L47.5 14.5C51.6 10.4 58.3 10.4 62 14.1C65.7 17.8 65.7 24.5 61.6 28.6L47.8 42.4C43.7 46.5 37 46.5 32.9 42.4L30.5 40" | ||
| stroke="currentColor" | ||
| strokeWidth="4" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| /> | ||
| </svg> | ||
| </div> | ||
|
|
@@ -433,22 +435,8 @@ function SupportUsButton( | |
| <div className="mt-20 sm:mt-24 flex flex-col min-[1380px]:flex-row items-center justify-between gap-6 sm:gap-8 text-center"> | ||
| <div className="flex flex-col items-center text-center text-base sm:text-lg font-normal whitespace-nowrap flex-none"> | ||
| <span className="flex items-center justify-center gap-1.5 whitespace-nowrap"> | ||
| <span>Supported By Global</span> | ||
| <svg | ||
| width="11" | ||
| height="11" | ||
| viewBox="0 0 62 62" | ||
| fill="none" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| className="flex-none" | ||
| > | ||
| <path | ||
| d="M35.431 0C39.6228 8.98514 51.2756 26.334 61.8182 26.334V35.4842H61.7276C47.2295 35.4842 35.431 47.2982 35.431 61.8182H26.29V61.8117C26.29 48.5541 33.5892 36.9699 44.3778 30.8816C40.0924 28.447 34.1734 20.7486 31.2286 16.7965C32.3689 14.2417 32.9599 13.6397 33.9892 10.0793M35.431 0C35.431 9.48036 31.7474 18.3846 25.0503 25.0911C22.7914 27.358 20.2371 29.3101 17.4566 30.8945C21.7293 33.3253 27.4488 41.3542 30.3815 45.2706C28.7626 48.7871 27.3396 58.2747 26.29 61.8182C22.2439 53.2247 11.1964 35.9179 1.20736 35.4648C0.803828 35.4777 0.401375 35.4842 0 35.4842V26.2822C0.405691 26.2822 0.808144 26.2887 1.20736 26.3016C7.76299 26.0151 13.9707 23.272 18.596 18.6176C21.0456 16.1771 22.9869 13.275 24.3076 10.0793C25.6283 6.88363 26.3021 3.45778 26.29 0H35.431Z" | ||
| fill="currentColor" | ||
| /> | ||
| </svg> | ||
| <span>Supported By</span> | ||
| </span> | ||
| <span className="whitespace-nowrap text-center">Powerhouses</span> | ||
| </div> | ||
|
|
||
| <div className="flex flex-wrap items-center justify-center min-[1380px]:justify-end gap-3 sm:gap-4 md:gap-6 lg:gap-8 select-none flex-1 w-full py-1"> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Externalize the changed user-visible strings.
The new
Support,A project made by, andSupported Bystrings are hardcoded in JSX. Add them to the project’s i18n resource files and render localized values.As per path instructions, user-visible strings should be externalized to resource files (i18n).
Also applies to: 289-290, 438-438
🤖 Prompt for AI Agents
Source: Path instructions