Skip to content

fix: add close button to debate setup popup - #570

Open
zaibamachhaliya wants to merge 1 commit into
AOSSIE-Org:mainfrom
zaibamachhaliya:fix/debate-setup-close-button
Open

zaibamachhaliya wants to merge 1 commit into
AOSSIE-Org:mainfrom
zaibamachhaliya:fix/debate-setup-close-button

Conversation

@zaibamachhaliya

@zaibamachhaliya zaibamachhaliya commented Sep 19, 2026

Copy link
Copy Markdown

Addressed Issues:

Fixes #526

Screenshots/Recordings:

Before

DebateAI.-.Google.Chrome.2026-09-19.21-58-58.mp4

After:

DebateAI.-.Google.Chrome.2026-09-19.21-56-23.mp4

Additional Notes:

Implemented the close behavior for the Debate Setup popup without changing the existing popup functionality.

Changes made in frontend/src/Pages/OnlineDebateRoom.tsx:

  • Added a visible × close button.
  • Added backdrop click handling to close the popup.
  • Prevented clicks inside the popup from propagating to the backdrop.

AI Usage Disclosure:

We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.

Check one of the checkboxes below:

  • This PR does not contain AI-generated code at all.
  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

I have used the following AI models and tools: TODO

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions
  • If applicable, I have made corresponding changes or additions to the documentation
  • If applicable, I have made corresponding changes or additions to tests
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contribution Guidelines
  • Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
  • I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4c923292-a4f6-4618-ae1e-e1f632649b07

📥 Commits

Reviewing files that changed from the base of the PR and between 9f90f9b and 550b2cf.

📒 Files selected for processing (1)
  • frontend/src/Pages/OnlineDebateRoom.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Debate setup modal

Layer / File(s) Summary
Modal dismissal interactions
frontend/src/Pages/OnlineDebateRoom.tsx
The setup popup closes when the backdrop or the aria-label="Close debate setup" button is clicked. Inner modal clicks stop propagation.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: syedbarkath980

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue #526 requires a visible way to dismiss the Debate Setup popup. The change adds a button with aria-label="Close debate setup" that sets showSetupPopup to false. The backdrop also closes the p…
Out of Scope Changes check ✅ Passed The changes are limited to dismissal behavior in the Debate Setup popup in frontend/src/Pages/OnlineDebateRoom.tsx. The close button, backdrop handling, and event propagation control directly suppor…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and directly describes the main change: adding a close button to the Debate Setup popup. It also aligns with the broader close behavior implemented in the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitcordapp

gitcordapp Bot commented Sep 19, 2026

Copy link
Copy Markdown

Link your account with Gitcord

Thanks for opening this PR, @zaibamachhaliya!

To receive Discord notifications and contributor tracking for this organization:

  1. Join Discord: https://discord.gg/hjUhu33uAn
  2. In Discord, run /link zaibamachhaliya
  3. Paste the verification code into your GitHub bio (or a public gist)
  4. Click Verify in Discord (or run /verify-link zaibamachhaliya)

Once linked, Gitcord can notify you about reviews, merges, and more.

Posted by Gitcord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Debate Setup popup has no close button, trapping users

1 participant