Skip to content

arm64: dts: aspeed: Add Alert_L dts changes to SP7 board - #301

Open
sathyapk wants to merge 1 commit into
integ_sp8from
alert_l_dts_ghana
Open

arm64: dts: aspeed: Add Alert_L dts changes to SP7 board#301
sathyapk wants to merge 1 commit into
integ_sp8from
alert_l_dts_ghana

Conversation

@sathyapk

Copy link
Copy Markdown
Collaborator

Alert_L dts changes added for:

  • 2P: Ghana

Alert_L dts changes added for:
- 2P: Ghana

Reviewed-by: Akshay Gupta <akshay.gupta@amd.com>
Signed-off-by: Sathya Priya Kumar <sathyapriya.k@amd.com>
};
};

/ {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason why this block should be a root node of the device tree? why can't it be at the same node like other device configuration?

@mahkurap mahkurap left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be no more BMC builds on integ_sp8 until we make a rerelease on 6.18.20 kernel. dev_6.18.20 branch has all the changes towards this. Please submit a new PR to merge the changes to dev_6.18.20.

Another question is, if these changes are not done in the SP8 platforms, please plan to add them as part of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants