arm64: dts: Remove GPIO10 espi_default gpio-hog - #296
Conversation
Remove espi_default hog on GPIO10 (output-low). It is obsolete and not needed. Tested - - Tested on SP7 Ghana - Host booted without issue Signed-off-by: ankprasa <ankprasa@amd.com>
| gpio-hog; | ||
| gpios = <10 GPIO_ACTIVE_HIGH>; | ||
| output-low; | ||
| line-name = "espiboot_pin_default"; |
There was a problem hiding this comment.
why dont we need to do similar changes for other platforms? I see that the same line-name is defined in Congo dts, but in gpio1. Is there a specific reason?
There was a problem hiding this comment.
gpio-hog was added earlier during bringup on all dts, and later removed. Ghana and Nigeria missed it.
This gpio is initialized in platform-init based on QSPI or eSPI variant detected.
There was a problem hiding this comment.
@rajaganeshr we are missing something here. integ_sp8 has the definition of gpio0 with the gpio-hog deleted. https://github.com/AMDESE/linux-aspeed/blob/integ_sp8/arch/arm64/boot/dts/aspeed/aspeed-bmc-amd-congo.dts#L978. dev_6.18.20 has the gpio1 defined with gpio-hog. https://github.com/AMDESE/linux-aspeed/blob/integ_sp8/arch/arm64/boot/dts/aspeed/aspeed-bmc-amd-congo.dts#L978. Please check. I noticed this discrepancy in the Congo device tree. Not sure where we got deviated. Please check, and also we may want to check all the other device trees in the dev_6.18.20 branch for consistency.
| @@ -694,12 +694,6 @@ pmic_ ## bus ## _ ## index: pmic@addr{ \ | |||
|
|
|||
| &gpio0 { | |||
There was a problem hiding this comment.
Are you sure we want to merge this change to dev-a2 branch which hosts only Arthur related changes? I think you want this to be merged to dev_6.18.20 branch. please check.
There was a problem hiding this comment.
will merge in dev_6.18.20. thanks for pointing out
3 participants
Remove espi_default hog on GPIO10 (output-low).
It is obsolete and not needed.
Tested -