fix: support run_on_local_node in gemm_throttling - #130
Merged
linamy85 merged 1 commit intoAug 20, 2026
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a run_on_local_node parameter to the gemm_throttling benchmark function to allow running on local node devices. However, the reviewer pointed out a critical issue: introducing this parameter without updating gemm_throttling_calculate_metrics will cause incorrect metrics calculations in multi-node environments, as the global device count will be used instead of the local device count. The reviewer provided a code suggestion to fix this by passing the correct device count based on run_on_local_node.
simrankaurb
force-pushed
the
fix-gemm-throttling-local-node
branch
from
August 20, 2026 06:32
701ca27 to
9c751be
Compare
simrankaurb
force-pushed
the
fix-gemm-throttling-local-node
branch
from
August 20, 2026 06:33
9c751be to
637f785
Compare
linamy85
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support configurable mesh locality (
run_on_local_node) ingemm_throttlingto allow running GEMM thermal soak microbenchmarks on single host devices across multi-node clusters.Rationale & Context
Following the design in #125,
run_on_local_nodeallows running microbenchmarks per single host (jax.local_devices()) rather than over the entire global cluster slice (jax.devices()).Changes Included
gemm_throttling(): Addedrun_on_local_node: bool = Falseparameter and passedlocal_mesh=run_on_local_nodetocreate_mesh().gemm_throttling_calculate_metrics(): Addedrun_on_local_node: bool = Falseparameter and setdevice_count = jax.local_device_count() if run_on_local_node else jax.device_count()when callinghandle_based_on_sharding(). This prevents inflated total FLOPs and throughput metrics in multi-node environments.