feat: Add p10 and p90 percentile metrics for performance tracking - #129
Merged
simonleesyuan30 merged 1 commit intoAug 14, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates HBM and FLOPS benchmark scripts to calculate, print, and record p90 metrics for step time, bandwidth, and throughput. The review feedback suggests improving consistency and completeness by also recording the median (p50) metrics for time and bandwidth in the HBM benchmark metadata, as well as printing and recording the p90 total throughput across all devices in the FLOPS benchmark.
simrankaurb
force-pushed
the
feat-p90-metrics
branch
14 times, most recently
from
August 14, 2026 10:07
466ba1e to
80db69a
Compare
simrankaurb
changed the title
simrankaurb
force-pushed
the
feat-p90-metrics
branch
from
August 14, 2026 11:58
80db69a to
329da57
Compare
simrankaurb
force-pushed
the
feat-p90-metrics
branch
from
August 14, 2026 12:03
329da57 to
26f9506
Compare
simonleesyuan30
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
p10andp90percentile tracking for step time, throughput, bandwidth, and MFU statistics, providing better visibility into performance variance across microbenchmarks.Changes:
p10tracking to themetrics_listpercentile calculations.benchmark_hbm.pyandbenchmark_utils.pyto displayp10andp90metrics alongside the median (p50).Logs: https://paste.googleplex.com/5817900119228416