Include source_id and variant_label in batch report - #605
Merged
Conversation
Downstream tooling (access-moppy-progress) needs model and member identifiers to file a batch report without requiring them to be typed manually, mirroring the existing experiment_id field.
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
=====================================
Coverage 75.1% 75.1%
=====================================
Files 38 38
Lines 8070 8070
Branches 1517 1517
=====================================
Hits 6061 6061
Misses 1688 1688
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_idandvariant_labelto the top-levelmoppy_batch_report.jsonoutput, sourced frombatch_config.ymlthe same wayexperiment_idalready is.access-moppy-progressdashboard registry'smanage-submissioncommand) resolve model/member identifiers directly from the report instead of requiring them to be typed manually on every submission.Test plan
pixi run -e test pytest tests/unit/test_batch_report.py -q— 27 passed