Skip to content

Wait for the shared store read in the shared choice test #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jwrosewell wants to merge 1 commit into
base: rc
Choose a base branch
from
Draft

Wait for the shared store read in the shared choice test #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions Browser51Did/PmpAcceptanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,16 +230,20 @@ private void SharedChoice(string browser)
visitor.WaitForPmp();
visitor.WaitForClientRounds(1);

var read = visitor.SharedStoreRequests()
.FirstOrDefault(r => r.Method == "GET" && r.Done);
Assert.IsNotNull(
read,
"PMP must ask the shared store what this visitor "
+ "already chose. It made no such call. The requests were: "
// The read can still be in flight when the first client round ends,
// because the two calls are separate and a remote cloud answers
// them in its own time.
Harness.Until(
() => visitor.SharedStoreRequests()
.Any(r => r.Method == "GET" && r.Done),
"PMP asked the shared store what this visitor already chose in "
+ $"{browser}. The requests were: "
+ string.Join(" || ",
visitor.Requests().Select(r => r.ToString())));
var read = visitor.SharedStoreRequests()
.First(r => r.Method == "GET" && r.Done);
Assert.IsTrue(
read!.Response.Contains("standard", StringComparison.Ordinal),
read.Response.Contains("standard", StringComparison.Ordinal),
"the shared store must answer with the choice made on the other "
+ $"site. It answered: {Truncate(read.Response)}");

Expand Down
Loading