Skip to content

Give the .NET example the _51DEGREES_ variable names alongside the old ones #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwrosewell merged 2 commits into from
Nov 11, 2026
Merged

Give the .NET example the _51DEGREES_ variable names alongside the old ones #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3d5d0b
Test that the .NET example is given the underscore variable names
jwrosewell Nov 11, 2026
01126f7
Give the .NET example the _51DEGREES_ variable names
jwrosewell Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Examples/ExampleApps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,13 @@ public static ExampleAppOptions BuildOptions(
StartupTimeoutSeconds: 180,
BuildEnv: o => new Dictionary<string, string>
{
// The example reads the _51DEGREES_ names. Released
// versions of it read the two older names, so both
// are set until every language has released.
["_51DEGREES_RESOURCE_KEY"] = o.ResourceKey,
["SUPER_RESOURCE_KEY"] = o.ResourceKey,
// the endpoint must include the api/v4 path
["_51DEGREES_CLOUD_ENDPOINT"] = new Uri(o.CloudEndpoint, "api/v4/").ToString(),
["FIFTYONE_CLOUD_ENDPOINT"] = new Uri(o.CloudEndpoint, "api/v4/").ToString(),
["ASPNETCORE_URLS"] = $"http://localhost:{o.Port}",
// run on a newer .NET runtime if the exact one isn't installed
Expand Down
20 changes: 20 additions & 0 deletions Examples/ExampleAppsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using Microsoft.VisualStudio.TestTools.UnitTesting;

Expand Down Expand Up @@ -74,5 +76,23 @@ public void Descriptors_Rust_BuildsAndRunsWithCargo()
Assert.IsTrue(rust.Args.Contains("dd-web-getting-started-cloud"),
"run args should target the cloud getting-started web binary");
}

[TestMethod]
public void Descriptors_Dotnet_SetsTheUnderscoreNames()
{
var dotnet = ExampleApps.Descriptors["dotnet"];
var env = dotnet.BuildEnv(new ExampleAppOptions(
Port: 5123,
CloudEndpoint: new Uri("https://cloud.example.test/"),
ResourceKey: "key",
ExtraEnv: new Dictionary<string, string>()));
Assert.AreEqual("key", env["_51DEGREES_RESOURCE_KEY"],
"the example reads the resource key from this name");
Assert.AreEqual(
"https://cloud.example.test/api/v4/",
env["_51DEGREES_CLOUD_ENDPOINT"],
"the example reads the endpoint, with its api/v4 path, "
+ "from this name");
}
}
}
Loading