Repository navigation
Test the Go JavaScript builder against the template under review - #47
Draft
jwrosewell wants to merge 1 commit into
Draft
jwrosewell wants to merge 1 commit into
jwrosewell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
consumer-tests.ymlbuilds the JavaScript builders of .NET, Java, Node, Python, PHP and Rust against a change to the template, so a change that suits one builder and breaks another is found here. Go's builder in 51degrees-go renders the same template and is not among them, so a change that breaks it is found only once Go's copy of the template moves.What changed
All in
.github/workflows/consumer-tests.yml.gojob, built as therustjob is. It checks out 51degrees-go atmain, or at the newgo-refinput when the workflow is started by hand. It copies the template under review over Go's embedded copy,pipeline/elements/javascriptbuilder/javascript-templates/JavaScriptResource.mustache, and says whether that copy differs from the revision under review, as the PHP and Rust jobs do. It also puts the template in the folder of 51degrees-go'sjavascript-templatessubmodule, because Go's tests render the submodule's template and check the embedded copy equals it (shared_template_test.go). Then it runsgo teston thejavascriptbuilderpackage, with the Go versionpipeline/go.modnames.Runs
The checks on this pull request ran on b164ffd, merged into
rce74ad3b.51degrees-go JavaScript builderjob checked out 51degrees-gomain, gave the notice that Go's copy is identical to the revision under review, set up Go 1.22.12 frompipeline/go.mod, and passed every test of thejavascriptbuilderpackage,TestTemplateIsTheSharedTemplateandTestScriptIsTheSharedTemplateRenderedamong them, so the shared template was read rather than skipped. The PHP and Rust jobs warn that their copies differ from the revision under review, which this change does not touch.