Repository navigation
Copy the OWID source into fodid before the Rust builder tests - #44
Merged
Merged
Conversation
jwrosewell
marked this pull request as ready for review
November 3, 2026 21:42
jwrosewell
added a commit
that referenced
this pull request
Nov 4, 2026
* Run the .NET consumer test against 51degrees-dotnet pipeline-dotnet has moved into 51degrees-dotnet, under pipeline/. The consumer test checks out the monorepo with its direct submodules, swaps the files under review into their new folder and runs the same test project from pipeline/, whose global.json pins the .NET 8 SDK. * Build the Node consumer test from 51degrees-node * Test the Python consumer from 51degrees-python pipeline-python has moved into 51degrees-python, where the Pipeline API packages are under pipeline/. Check out the monorepo with only its direct submodules, so the cxx data files are not fetched, and swap the template in at its new path. * Check out the Rust SDK as 51degrees-rust (#34) The rust repository is now 51degrees-rust (51Degrees/51degrees-rust#206). The Rust job checks it out by the new name, and its job name, step name, input description and notices say 51degrees-rust. The job id and the rust-ref input keep their names, because an id can't start with a digit. * Build the Java consumer test from 51degrees-java (#36) * ci: test the PHP consumer from 51degrees-php (#38) pipeline-php-core is now a read-only mirror. The PHP job checks out the monorepo, swaps the template into pipeline/core and runs that package's unit tests there. * Check that only rc merges into the default branch (#40) * Copy the OWID source into fodid before the Rust builder tests (#44) --------- Co-authored-by: James Rogers <JamesR@51degrees.com> Co-authored-by: Eugene Dorfman <justadreamer2007@gmail.com> Co-authored-by: ben51degrees <ben@51degrees.com> Co-authored-by: Yaroslav <Yaroslavvlasenko@gmail.com>
jwrosewell
added a commit
that referenced
this pull request
Nov 12, 2026
* Run the .NET consumer test against 51degrees-dotnet pipeline-dotnet has moved into 51degrees-dotnet, under pipeline/. The consumer test checks out the monorepo with its direct submodules, swaps the files under review into their new folder and runs the same test project from pipeline/, whose global.json pins the .NET 8 SDK. * Build the Node consumer test from 51degrees-node * Test the Python consumer from 51degrees-python pipeline-python has moved into 51degrees-python, where the Pipeline API packages are under pipeline/. Check out the monorepo with only its direct submodules, so the cxx data files are not fetched, and swap the template in at its new path. * Check out the Rust SDK as 51degrees-rust (#34) The rust repository is now 51degrees-rust (51Degrees/51degrees-rust#206). The Rust job checks it out by the new name, and its job name, step name, input description and notices say 51degrees-rust. The job id and the rust-ref input keep their names, because an id can't start with a digit. * Build the Java consumer test from 51degrees-java (#36) * ci: test the PHP consumer from 51degrees-php (#38) pipeline-php-core is now a read-only mirror. The PHP job checks out the monorepo, swaps the template into pipeline/core and runs that package's unit tests there. * Check that only rc merges into the default branch (#40) * Copy the OWID source into fodid before the Rust builder tests (#44) * Add the licence as LICENSE, in the form 51degrees-cxx uses (#45) * Add the licence as LICENSE and NOTICE, in the form 51degrees-cxx uses The repository had no licence file. LICENSE is the plain EUPL v1.2 text, byte for byte the file in 51degrees-cxx, and NOTICE holds the two additional terms that every 51Degrees source header repeats. The test script now carries the licenseText of the CopyrightUpdater settings in the tools repository. * Keep the licence in LICENSE alone, with no NOTICE The two additional terms are stated in the header of every source file, which is where they apply, so NOTICE is removed, as in 51degrees-cxx. --------- Co-authored-by: James Rogers <JamesR@51degrees.com> Co-authored-by: Eugene Dorfman <justadreamer2007@gmail.com> Co-authored-by: ben51degrees <ben@51degrees.com> Co-authored-by: Yaroslav <Yaroslavvlasenko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 51degrees-rust consumer job fails to compile the fodid crate with
error[E0583]: file not found for module owid, for example in run 41697881387 on the release pull request #43.fodid compiles the OWID source in as a private module.
fodid/src/lib.rsline 359 declaresmod owid;, and 51degrees-rust'sci/copy-owid-source.ps1copies that source from the owid-rust submodule intofodid/src/owid, which its.gitignoreexcludes (lines 25 to 28). 51degrees-rust's own pull request workflow runs the script before every build, as its step "Copy the OWID source into fodid". This job checked out the submodule but never ran the script.This adds the same step to the job, just before the tests, run from the checkout so the script's default root is the 51degrees-rust working copy. Only
.github/workflows/consumer-tests.ymlchanges.How this was checked
The consumer tests run on this pull request, and the 51degrees-rust job is the one to look at.