Repository navigation
Build the Python consumer test from 51degrees-python - #42
Open
justadreamer wants to merge 1 commit into
Open
justadreamer wants to merge 1 commit into
justadreamer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python repositories pipeline-python, device-detection-python and location-python have been merged into the 51degrees-python monorepo and are archived. The PyPI package names are unchanged.
The Python consumer test checks out 51degrees-python, swaps the template under review into
pipeline/fiftyone_pipeline_core/src/fiftyone_pipeline_core/js_templates, and runs the JavaScript builder tests frompipeline/fiftyone_pipeline_core. It checks out submodules non-recursively, so it fetches 51degrees-cxx but not the data files under it. Thepipeline-python-refinput keeps its name so existing dispatches still work, and now names a 51degrees-python ref.Tested:
pip install -e .andpytest tests/test_javascriptbuilder.pyinpipeline/fiftyone_pipeline_coreof a fresh 51degrees-python checkout pass (11 tests).