Skip to content

Test the Python consumer from 51degrees-python - #41

Merged
jwrosewell merged 1 commit into
rcfrom
ci/python-consumer-from-monorepo
Nov 3, 2026
Merged

jwrosewell merged 1 commit into
rcfrom
ci/python-consumer-from-monorepo

Conversation

@jwrosewell

Copy link
Copy Markdown
Contributor

The Python consumer test still checks out pipeline-python, whose code has moved into 51degrees-python. This points the test at the monorepo, as #36, #37, #38 and #39 do for Java, .NET, PHP and Node.

Change

  • .github/workflows/consumer-tests.yml checks out 51Degrees/51degrees-python and swaps the template in at pipeline/fiftyone_pipeline_core/src/fiftyone_pipeline_core/js_templates, which is where the submodule is in the monorepo's .gitmodules. The tests run from pipeline/fiftyone_pipeline_core, where tests/test_javascriptbuilder.py is.
  • Submodules are checked out one level deep instead of recursively, so the data files under cxx/ aren't fetched, as in the Java and Node changes.
  • The input pipeline-python-ref and the job id keep their names, as in the other changes, so existing dispatches still work.
  • The README's list of consumers names 51degrees-python.

Note for merging

The other four pull requests change neighbouring lines of the same README list, so whichever merges later needs the list resolved by hand. Each line changes independently.

pipeline-python has moved into 51degrees-python, where the Pipeline API
packages are under pipeline/. Check out the monorepo with only its
direct submodules, so the cxx data files are not fetched, and swap the
template in at its new path.
@jwrosewell

Copy link
Copy Markdown
Contributor Author

The 51degrees-python JavaScript builder job passed in run 41675267530. The run is red only because the rust JavaScript builder job fails to compile (file not found for module owid), which it does on every branch's consumer test run today, so it isn't caused by this change.

@jwrosewell
jwrosewell merged commit 08073e9 into rc Nov 3, 2026
6 of 7 checks passed
@jwrosewell
jwrosewell deleted the ci/python-consumer-from-monorepo branch November 3, 2026 18:49
@jwrosewell jwrosewell mentioned this pull request Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant