Repository navigation
Test the Python consumer from 51degrees-python - #41
Merged
Merged
Conversation
pipeline-python has moved into 51degrees-python, where the Pipeline API packages are under pipeline/. Check out the monorepo with only its direct submodules, so the cxx data files are not fetched, and swap the template in at its new path.
Contributor
Author
|
The 51degrees-python JavaScript builder job passed in run 41675267530. The run is red only because the rust JavaScript builder job fails to compile ( |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python consumer test still checks out pipeline-python, whose code has moved into 51degrees-python. This points the test at the monorepo, as #36, #37, #38 and #39 do for Java, .NET, PHP and Node.
Change
.github/workflows/consumer-tests.ymlchecks out 51Degrees/51degrees-python and swaps the template in atpipeline/fiftyone_pipeline_core/src/fiftyone_pipeline_core/js_templates, which is where the submodule is in the monorepo's.gitmodules. The tests run frompipeline/fiftyone_pipeline_core, wheretests/test_javascriptbuilder.pyis.cxx/aren't fetched, as in the Java and Node changes.pipeline-python-refand the job id keep their names, as in the other changes, so existing dispatches still work.Note for merging
The other four pull requests change neighbouring lines of the same README list, so whichever merges later needs the list resolved by hand. Each line changes independently.