This repository was archived by the owner on Nov 13, 2026. It is now read-only.
Repository navigation
Add the licence as LICENSE, in the form 51degrees-cxx uses - #44
Merged
Merged
Conversation
The repository had no licence file. LICENSE is the plain EUPL v1.2 text, byte for byte the file in 51degrees-cxx and data, and NOTICE holds the two additional terms that every 51Degrees source header repeats.
The two additional terms are stated in the header of every source file, which is where they apply, so NOTICE is removed, as in 51degrees-cxx.
jwrosewell
changed the title
Contributor
Author
|
Closing and reopening at once to start the checks again, because the runs queued during GitHub's Actions outage this evening never started. |
jwrosewell
marked this pull request as ready for review
November 11, 2026 23:49
Merged
jwrosewell
added a commit
that referenced
this pull request
Nov 12, 2026
* Check that only rc merges into the default branch (#41) * Add the licence as LICENSE, in the form 51degrees-cxx uses (#44) * Add the licence as LICENSE and NOTICE, in the form 51degrees-cxx uses The repository had no licence file. LICENSE is the plain EUPL v1.2 text, byte for byte the file in 51degrees-cxx and data, and NOTICE holds the two additional terms that every 51Degrees source header repeats. * Keep the licence in LICENSE alone, with no NOTICE The two additional terms are stated in the header of every source file, which is where they apply, so NOTICE is removed, as in 51degrees-cxx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Into
rc, where this repository takes every change (#41 merged intorc, and the "Only rc into main" check refuses any other branch intomain). Branched fromrcat d5a961c.The problem
The repository had no licence file, so GitHub reports no licence for it.
What this follows
The licence decision for every 51Degrees repository is one
LICENSEat the root holding the standard EUPL v1.2 text and noNOTICE, with the two additional terms in the standard 51Degrees header of every source file. The referenceLICENSEis the one in 51degrees-cxx (blob a74f04438a at 9ab640e3), whoseNOTICEis removed by 51degrees-cxx#151.What changed
LICENSE, the cxx file byte for byte (git hash-objectgives a74f04438a883d3366e2dbbed63d728a452fff06), which is also the rootLICENSEof data. There is noNOTICE.Source headers
The repository holds data files, translations, evidence files and scripts. The scripts (
evidence-gen.ps1,get-lite-file-from-azure.ps1,get-lite-file-from-azure.sh,ci/run-unit-tests.ps1andtests/check-dl-script.tests.ps1) carry no header, and are left as they are, because the CI and helper scripts of 51degrees-cxx carry none either (checked in all 17) and the CopyrightUpdater has no setting for.ps1or.sh. There are no other source files.How it was checked
Checks on head 17d5f8c, all green.
Licence-only, no full build under the 20:50 decision, because the diff only adds
LICENSE. Nothing here changes behaviour, so there is no red run.For whoever merges this
The first commit, aaeaaf7, is headlined "Add the licence as LICENSE and NOTICE, in the form 51degrees-cxx uses", and it did add a
NOTICE. The decision of about 20:05 UTC on 11 November is that no repository holds one, so the second commit, 17d5f8c, removes it and is headlined "Keep the licence in LICENSE alone, with no NOTICE". The net diff addsLICENSEalone. This is a public repository, so please squash on merge with the second headline, rather than take a merge commit that keeps the first message in the history. The same two commit pattern is in derived-properties#17, javascript-templates#45, data#12 and device-detection-data#182, for the same reason.After this merges
This repository is the
ip-intelligence-datasubmodule of 51degrees-cxx, kept there for the language repositories, so the cxx pin moves once this reachesmain, and the language repositories follow when they next move to cxx. The release coordinator arranges both.