Repository navigation
Link the Go derived property example - #322
Merged
Merged
Conversation
51degrees-go#137 added the example after the derived property page was written. The Go tab now links it and says what it shows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The derived property page, added by #315 and merged into
rcon 15 November, links the Rust example but not Go's, because Go's was still a draft when the page was written. 51degrees-go#137 merged it into Go'srcat 00:32 UTC on 15 November.What the specification says
required-examples.mdlines 30 to 52 at b3b2c0dd say every reference implementation MUST provide one example for the Derived Property Element, and that it MUST show a script held in the example and passed as text, a script read from a file beside the example, the same Pipeline built from a configuration file, and what the caller sees when a source Property is not available.What changed
src/pipelineapi/features/derivedproperties.md, the Go tab. One sentence links the example,examples/pipeline/7_derived_property/main.go, and says what it shows, which is each of the four.AddScriptat line 225.ReaderEngagement.yamlbeside it,AddScriptFileat line 223.config.json,BuildFromConfigurationat line 187.session.PointerMoved, at line 140, whose derived properties then have no value and print the message naming it.The page links
blob/main, like its other links to the language repositories.When this merges
After Go's Monday release reaches
main, because the example is on Go'srcuntil then.What remains
Node.js (51degrees-node#98) and Python (51degrees-python#125) have the element in open drafts, and Java has none yet. Each gets a tab on the page once its change is merged.
Build
Checks on the head, 425834d, all green.
derivedproperties.md..utm-lint.json({ "mode": "forbid" }) requires.