Repository navigation
Add Node.js, Python and PHP tabs to the IP Intelligence quick start - #320
Merged
Merged
Conversation
Each tab names the package, how to get it and the console and web examples on GitHub, as the Go and Rust tabs do. PHP's package is not on Packagist, so its tab says to use a clone and links the guide to building the extension.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The IP Intelligence quick start has tabs for C, C++, .NET, Java, Go and Rust, and none for Node.js, Python or PHP, although all three have IP Intelligence for the cloud and on-premise. PHP's became usable alongside Device Detection with 51degrees-php#88, on PHP's
rcfor the release on Monday 16 November, which loads both on-premise extensions in one PHP. The feature matrix draft now shows IP Intelligence for all three.What changed
src/ipintelligence/quickstart.mdgains a Node.js, a Python and a PHP tab, in the shape of the Go and Rust tabs. The example pages this quick start links for the other languages grab their examples from published API documentation, which none of these three languages has for IP Intelligence, so each tab links the examples on GitHub.51degrees/fiftyone.ipintelligence, not on Packagist (https://repo.packagist.org/p2/51degrees/fiftyone.ipintelligence.jsonanswered 404 on 14 November, and the README, lines 105 to 107, says it has no mirror)The tabs link
blob/main, like the rest of the page, so they name the files the Monday releases put onmain.When this merges
After the Monday 16 November releases reach
main, because the PHP tab rests on 51degrees-php#88.What remains
Nothing in this repository.
Build
Checks on the head, ba44f05, all green.
quickstart.md..utm-lint.json({ "mode": "forbid" }) requires.