Repository navigation
Give UserAgents as an empty list when the option is off, and send no usage data from the web example test - #168
Merged
Merged
Conversation
…matched User-Agents
…e test runs and closes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups from this week's drafts. UserAgents is an empty list when the engine does not record the matched User-Agents, as the specification's default says, and the Device Detection web example test sends no usage data from CI.
Closes #163. Closes #150.
Problem
update_matched_useragent=Falsethe native results still give one matched User-Agent per result, each empty, so UserAgents was[""](one empty string, which #145 lists once), andtest_turned_off_leaves_user_agents_emptyexpected empty strings (#163).test_onpremisegettingstartedweb.pybuilds the on-premise web example from itsconfig.json, which shares usage, and closes its Pipeline when the tests end, so every CI run sent real usage data (#150).What the specification says
The match metric table in device-detection-on-premise.md lines 466 to 476 at 706de1f0 gives UserAgents the default value
[]and says it is "Populated when the Update Matched User Agent configuration option is on".What changed
DeviceDetectionOnPremisekeeps whether it records the matched User-Agents, being on unlessupdate_matched_useragentis given as false, as the native default is on, andSwigDatagives UserAgents as[]when it does not. The test now expects[].test_onpremisegettingstartedweb.pyreplacesrequests.postfrom the start of its tests until the example's Pipeline has closed, so what usage sharing sends goes to the stand-in. Test only.Before you upgrade
update_matched_useragent=False, UserAgents is[], where it was[""].How it was verified
rc8d05fe2. In all ten jobs onlytest_turned_off_leaves_user_agents_emptyfailed, "1 failed, 83 passed" in the on-premise Device Detection tests.rc28e5bf2, is green. Its ten Build and Test jobs, Python 3.10 to 3.14 on Ubuntu and Windows, each passed, withtest_update_matched_useragent.py(4 tests) andtest_onpremisegettingstartedweb.py(6 tests) passing in each. The 11Setting 'PullRequestSha'lines all name 315e305, and Configure printed "Left out 5 macOS entries". macOS was left out of this draft's full build under the 9 November decision. The rc head is built with macOS before it merges into main.requests.post, which no test can see being called for real.What it releases
fiftyone_devicedetection_onpremiseand its dependants, which Monday's release plan releases already.What remains
Nothing.