Skip to content

Give UserAgents as an empty list when the option is off, and send no usage data from the web example test - #168

Merged
jwrosewell merged 3 commits into
rcfrom
fix/small-followups
Nov 15, 2026
Merged

jwrosewell merged 3 commits into
rcfrom
fix/small-followups

Conversation

@jwrosewell

@jwrosewell jwrosewell commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Two follow-ups from this week's drafts. UserAgents is an empty list when the engine does not record the matched User-Agents, as the specification's default says, and the Device Detection web example test sends no usage data from CI.

Closes #163. Closes #150.

Problem

  1. UserAgents with the option off. With update_matched_useragent=False the native results still give one matched User-Agent per result, each empty, so UserAgents was [""] (one empty string, which #145 lists once), and test_turned_off_leaves_user_agents_empty expected empty strings (#163).
  2. Usage data from CI. test_onpremisegettingstartedweb.py builds the on-premise web example from its config.json, which shares usage, and closes its Pipeline when the tests end, so every CI run sent real usage data (#150).

What the specification says

The match metric table in device-detection-on-premise.md lines 466 to 476 at 706de1f0 gives UserAgents the default value [] and says it is "Populated when the Update Matched User Agent configuration option is on".

What changed

  1. DeviceDetectionOnPremise keeps whether it records the matched User-Agents, being on unless update_matched_useragent is given as false, as the native default is on, and SwigData gives UserAgents as [] when it does not. The test now expects [].
  2. test_onpremisegettingstartedweb.py replaces requests.post from the start of its tests until the example's Pipeline has closed, so what usage sharing sends goes to the stand-in. Test only.

Before you upgrade

  • With update_matched_useragent=False, UserAgents is [], where it was [""].

How it was verified

  • Red, full build 43652293282 on b47570f, the UserAgents test alone on rc 8d05fe2. In all ten jobs only test_turned_off_leaves_user_agents_empty failed, "1 failed, 83 passed" in the on-premise Device Detection tests.
  • Green, full build 43654803703 on the head 315e305, from rc 28e5bf2, is green. Its ten Build and Test jobs, Python 3.10 to 3.14 on Ubuntu and Windows, each passed, with test_update_matched_useragent.py (4 tests) and test_onpremisegettingstartedweb.py (6 tests) passing in each. The 11 Setting 'PullRequestSha' lines all name 315e305, and Configure printed "Left out 5 macOS entries". macOS was left out of this draft's full build under the 9 November decision. The rc head is built with macOS before it merges into main.
  • The web example test change is a test only, so it has no red. It stands in for requests.post, which no test can see being called for real.

What it releases

fiftyone_devicedetection_onpremise and its dependants, which Monday's release plan releases already.

What remains

Nothing.

@jwrosewell
jwrosewell marked this pull request as ready for review November 15, 2026 01:02
@jwrosewell
jwrosewell merged commit 1190974 into rc Nov 15, 2026
3 checks passed
@jwrosewell
jwrosewell deleted the fix/small-followups branch November 15, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant