Repository navigation
Say in the nightly schedule comment that the Node.js nightly starts at 02:30 - #135
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment above the Nightly Pipeline's schedule says why this nightly starts at 05:00 UTC. Part of it went out of date when the Node.js nightly moved earlier.
Problem
.github/workflows/nightly-pipeline.ymllines 17 to 20 at cf904f8e say "The Java and Node nightlies start at 03:00". 51degrees-node#27 moved the Node.js nightly to 02:30 UTC (nightly-pipeline.ymlline 10 at 6d5d4fef,cron: '30 2 * * *'), and that reaches Node.jsmainwith its next release. The Java nightly still starts at 03:00 (nightly-pipeline.ymlline 13 at f212dfc9).What changed
The comment now says the Node.js nightly starts at 02:30 and the Java nightly at 03:00, and that both want macOS runners, so this one starts after them. The schedule itself (
cron: '0 5 * * *') does not change, and no other line changes.How it was verified
This changes a comment in a workflow file and no package code, so under the decision of 11:35 UTC on 12 November ("rebuild and include, but the change doesn't impact the code so no need to run the full builds") it has no full build of its own, and the quick checks on head 7d25073 are its build. All three passed, the environment variable name check (43613507888), Only rc into main (43613508064) and utm-link-lint (43613507828). Publish releases nothing for it, as the file is in no package's folder.
What remains
Nothing.