Remove the secrets no workflow has and the product workflow folders GitHub never runs

device-detection/.github/workflows/example-assets-update.yml → .github/workflows/example-assets-update.yml

@@ -3,12 +3,14 @@ name: Example Assets Update
 # Refreshes the shared web-example CSS/JS (examples-main) committed in this repo
 # from the latest examples-assets release, via the common-ci reusable workflow.
 # The assets change rarely, so this runs weekly and only opens a PR if they
-# changed. common-ci is not a submodule; it is referenced as a reusable workflow.
+# changed. It calls common-ci as a reusable workflow, not a submodule.
 
 on:
   workflow_dispatch:
+  # Mondays at 03:45 UTC, so it starts apart from the other repositories'
+  # example asset updates.
   schedule:
-    - cron: '0 3 * * 1'
+    - cron: '45 3 * * 1'
 
 jobs:
   Example_Assets_Update:

.github/workflows/nightly-pipeline.yml

@@ -35,13 +35,10 @@ jobs:
     secrets:
       token: ${{ secrets.ACCESS_TOKEN }}
       DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
-      DeviceDetectionUrl: ${{ secrets.DEVICE_DETECTION_URL }}
-      CsvUrl: ${{ secrets.CSV_URL }}
       IpIntelligence: ${{ secrets.IP_INTELLIGENCE_KEY }}
       IpIntelligenceUrl: ${{ secrets.IPI_DATA_FILE_URL }}
       TestResourceKey: ${{ secrets._51DEGREES_RESOURCE_KEY_BESPOKE }}
       PypiToken: ${{ secrets.PYPI_TOKEN }}
-      TestPypiToken: ${{ secrets.TEST_PYPI_TOKEN }}
 
   SubmoduleUpdate:
     name: Nightly Submodule Update
@@ -71,8 +68,6 @@ jobs:
     secrets:
       token: ${{ secrets.ACCESS_TOKEN }}
       DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
-      DeviceDetectionUrl: ${{ secrets.DEVICE_DETECTION_URL }}
-      CsvUrl: ${{ secrets.CSV_URL }}
       IpIntelligence: ${{ secrets.IP_INTELLIGENCE_KEY }}
       IpIntelligenceUrl: ${{ secrets.IPI_DATA_FILE_URL }}
       TestResourceKey: ${{ secrets._51DEGREES_RESOURCE_KEY_BESPOKE }}

.github/workflows/publish.yml

@@ -30,10 +30,7 @@ jobs:
     secrets:
       token: ${{ secrets.ACCESS_TOKEN }}
       DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
-      DeviceDetectionUrl: ${{ secrets.DEVICE_DETECTION_URL }}
-      CsvUrl: ${{ secrets.CSV_URL }}
       IpIntelligence: ${{ secrets.IP_INTELLIGENCE_KEY }}
       IpIntelligenceUrl: ${{ secrets.IPI_DATA_FILE_URL }}
       TestResourceKey: ${{ secrets._51DEGREES_RESOURCE_KEY_BESPOKE }}
       PypiToken: ${{ secrets.PYPI_TOKEN }}
-      TestPypiToken: ${{ secrets.TEST_PYPI_TOKEN }}

.github/workflows/pull-requests.yml

@@ -38,8 +38,6 @@ jobs:
     secrets:
       token: ${{ secrets.ACCESS_TOKEN }}
       DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
-      DeviceDetectionUrl: ${{ secrets.DEVICE_DETECTION_URL }}
-      CsvUrl: ${{ secrets.CSV_URL }}
       IpIntelligence: ${{ secrets.IP_INTELLIGENCE_KEY }}
       IpIntelligenceUrl: ${{ secrets.IPI_DATA_FILE_URL }}
       TestResourceKey: ${{ secrets._51DEGREES_RESOURCE_KEY_BESPOKE }}

.github/workflows/release-pull-request.yml

@@ -25,8 +25,6 @@ jobs:
     secrets:
       token: ${{ secrets.ACCESS_TOKEN }}
       DeviceDetection: ${{ secrets.DEVICE_DETECTION_KEY }}
-      DeviceDetectionUrl: ${{ secrets.DEVICE_DETECTION_URL }}
-      CsvUrl: ${{ secrets.CSV_URL }}
       IpIntelligence: ${{ secrets.IP_INTELLIGENCE_KEY }}
       IpIntelligenceUrl: ${{ secrets.IPI_DATA_FILE_URL }}
       TestResourceKey: ${{ secrets._51DEGREES_RESOURCE_KEY_BESPOKE }}

ci/fetch-assets.ps1

@@ -5,8 +5,6 @@ param (
     # common-ci checkout, which is where both callers run it from.
     [string]$RepoName = (Split-Path -Leaf (Split-Path -Parent $PSScriptRoot)),
     [string]$DeviceDetection,
-    [string]$DeviceDetectionUrl,
-    [string]$CsvUrl,
     [string]$IpIntelligence,
     [string]$IpIntelligenceUrl,
     # The branch a pull request merges into, which its changes are measured

device-detection/ci/README.md

@@ -10,7 +10,3 @@ The following secrets are required:
     * Example: `V3RYL0NGR4ND0M57R1NG`
 * `PYPI_TOKEN` - [PyPI token](https://pypi.org/help/#apitoken) for publishing packages
     * Example: `pypi-sUp3r-l0nG_r4nd0m-s7r1Ng`
-
-The following secrets are optional:
-* `DEVICE_DETECTION_URL` - URL for downloading the enterprise TAC hashes file
-    * Default: `https://distributor.51degrees.com/api/v2/download?LicenseKeys=DEVICE_DETECTION_KEY&Type=HashV41&Download=True&Product=V4TAC`

device-detection/ci/fetch-assets.ps1

@@ -1,7 +1,5 @@
 param (
-    [string]$DeviceDetection,
-    [string]$DeviceDetectionUrl,
-    [string]$CsvUrl
+    [string]$DeviceDetection
 )
 $ErrorActionPreference = 'Stop'
 
@@ -21,7 +19,7 @@ if ($DeviceDetection) {
     Write-Host "::warning file=$($MyInvocation.ScriptName),line=$($MyInvocation.ScriptLineNumber),title=No License Key::A device detection license was not provided, so On-Premise Data file and 51Degrees.csv will not be downloaded."
 }
 
-./steps/fetch-assets.ps1 -DeviceDetection:$DeviceDetection -DeviceDetectionUrl:$DeviceDetectionUrl -CsvUrl:$CsvUrl -Assets $assets
+./steps/fetch-assets.ps1 -DeviceDetection:$DeviceDetection -Assets $assets
 foreach ($asset in $assets) {
     switch -Exact -CaseSensitive ($asset) {
         'TAC-HashV41.hash' {New-Item -ItemType SymbolicLink -Force -Target "$PWD/assets/$_" -Path "$deviceDetectionData/Enterprise-HashV41.hash"}