Repository navigation
Let Publish be run with common-ci's early release option - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
common-ci's Publish refuses a release that comes less than a week after the last one, in its step "Refuse a release less than a week after the last" (
nightly-publish.ymlat 1c5c0e0b, withsteps/check-release-interval.ps1), unless the run sets itsallow-early-releaseinput. This repository'spublish.ymldoes not take that input, so a release inside the week could not be published at all once the rule applies.This repository released on 13 November (#114, Publish run 43378300268). James Rosewell asked at about 17:30 UTC on 13 November for a release of every repository on Monday 16 November, which is his permission for that release to go out early under the weekly rule.
What changed
.github/workflows/publish.ymlgains the inputallow-early-release, false by default, and passes it to common-ci'snightly-publish.yml, as 51degrees-php's Publish does in its draft #37. Nothing else changes. The nightly's publish is left without it, so a scheduled run never releases early. No option that moves a major or minor version is added.Checks
rcwith every Python draft for Monday merged, this one included, was dispatched asgh workflow run publish.yml --ref tmp/pyowner-sim3 -f dryrun=true -f allow-early-release=true(run 43501866018, at 2556107). Its Configure job (job 132149457735) shows the input reaching common-ci asallow-early-release: trueandALLOW_EARLY_RELEASE: true, and the step "Refuse a release less than a week after the last" passed, printing "The weekly release rule is not enforced, as WEEKLY_RELEASES_FROM is not set." So the input is accepted and passed on, and the rule is not yet in force for this repository.This draft changes only a workflow, with no package code. James Rosewell decided at about 11:35 UTC on 12 November, for a change only to CI, "rebuild and include, but the change doesn't impact the code so no need to run the full builds."
What remains
The Monday Publish is dispatched with
allow-early-releaseset to true anddryrunfalse, once the release has merged intomain.The last release into
mainwas #114, merged at 06:22 UTC on 13 November.